Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for vscode-icons #9194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

taquangtrung
Copy link
Contributor

Brief summary of what the package does

This library displays beautiful SVG icons adopted from modern VSCode extensions.

Direct link to the package repository

https://github.com/taquangtrung/vscode-icons.el

Your association with the package

Maintainer.

Relevant communications with the upstream package maintainer

N/A.

Checklist

@riscy
Copy link
Member
riscy commented Sep 29, 2024

Thanks for this. Quick first pass -

vscode-icons.el with package-lint 20240923.1044:

3 issues found:
1960:5: error: You should depend on (emacs "29.1") if you need `js-ts-mode'.
1984:5: error: You should depend on (emacs "29.1") if you need `tsx-ts-mode'.
1987:5: error: You should depend on (emacs "29.1") if you need `typescript-ts-mode'.

Also, why does your recipe -

(vscode-icons
    :fetcher github
    :repo "taquangtrung/vscode-icons.el"
    :files (:defaults "vscode-icons.png" "icons"))

include vscode-icons.png? This doesn't seem to be referenced anywhere in code that I can see.

@taquangtrung
Copy link
Contributor Author

Hi, thanks for the quick feedback!

vscode-icons.el with package-lint 20240923.1044:
3 issues found:
1960:5: error: You should depend on (emacs "29.1") if you need js-ts-mode'. 1984:5: error: You should depend on (emacs "29.1") if you need tsx-ts-mode'.
1987:5: error: You should depend on (emacs "29.1") if you need `typescript-ts-mode'.

These issues are false alarms. This package doesn't load js-ts-mode', tsx-ts-mode'. but they are used as the keys in an association list. Do you know how to disable the linter?

(defvar vscode-icons-mode-icon-alist
  '((LaTeX-mode                         ("file"           "tex.svg"))
    ...
    (js-jsx-mode                        ("file"           "js.svg"))
    (js-mode                            ("file"           "js.svg"))
    (js-ts-mode                         ("file"           "js.svg"))
    ...

Also, why does your recipe -

(vscode-icons
    :fetcher github
    :repo "taquangtrung/vscode-icons.el"
    :files (:defaults "vscode-icons.png" "icons"))

include vscode-icons.png? This doesn't seem to be referenced anywhere in code that I can see.

I removed vscode-icons.png. This file is referred in the README file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants