Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests from bpr following :defaults of :files #9181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jian-lin
Copy link
Contributor

cc package author @iliabv

ref: NixOS/nixpkgs#335442

@riscy
Copy link
Member
riscy commented Sep 22, 2024

Thanks both. Before I hit merge, I should note that if you rename this excluded file to bpr-tests.el or create a test subdirectory instead, then this recipe update won't be required. I'm happy to merge if this isn't straightforward - but the default recipe has a few small conventions in it like this that can be useful to rely on without having to make new PRs to MELPA.

Since I'm here checking, I can also point out a few salient issues:

  • 183:9: error: You should depend on (emacs "24.1") if you need `process-live-p'.
  • 194:11: error: You should depend on (emacs "24.1") if you need `process-live-p'.
  • 254:7: error: You should depend on (emacs "24.1") if you need `scroll-down-command'.
  • bpr.el needs formal license boilerplate and/or an SPDX-License-Identifier

@riscy
Copy link
Member
riscy commented Sep 29, 2024

@iliabv Thoughts on the previous comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants