Add support for any macOS terminal #100
Conversation
applescript/functions
Outdated
| else | ||
| return $? | ||
| else | ||
| return $? |
There was a problem hiding this comment.
I think this is less understandable then it was before — this clause is part of the outer if, so it should either be the way it was before, or on the same level (4 spaces less indent) as the outer if.
| } | ||
|
|
||
| # Find the top level parent PID of current shell (not including root process), also accounting for TMUX | ||
| function top-level-ppid { |
There was a problem hiding this comment.
This function will infinitely recurse if ps doesn’t take the expected options (maybe on other BSDs? I dunno), or if there is no process with PID 1 (maybe in a container?).
I’m not especially worried about this, but it could be prevented by setting setopt localoptions errexit here.
There was a problem hiding this comment.
but it could be prevented by setting
setopt localoptions errexithere
Tried to google this option and barely found anything. I think I fixed it much simpler :)
There was a problem hiding this comment.
That works too!
setopt localoptions errexit might be hard to google because zsh ignores underscores in the options. Just running setopt gives a list of options, which are reported without underscores, but the manual lists them with underscores. So the above is equivalent to setopt local_options err_exit.
local_optionscauses the shell options to only be set for the duration of the local function.err_exitcauses the shell to exit when a command fails, likeset -e. (It should probably have beenerr_returnwhich causes the function to return.)
Docs:
setoptin https://zsh.sourceforge.io/Doc/Release/Shell-Builtin-Commands.html forLOCAL_OPTIONSandERR_EXITin https://zsh.sourceforge.io/Doc/Release/Options.html (butERR_RETURNmight have been better)
|
This is very clever! I like it. I just had a couple of minor comments. |
|
@danielparks can you merge? Or is it necessary for someone else to review this? |
|
I cannot. Sorry, I couldn’t remember if this was one of the (few) repos I had access to. |
|
@marzocchi Hi! Please merge if this looks good to you, I'd really appreciate it. |
|
FWIW, I have been using this PR with ghostty without issue. |
|
This fixes an "unsupported environment" message when loading up within VSCode too |
|
nit: reflect the change in the README |
|
@marzocchi This really improves the experience on macOS. Can we get it merged? |
After this change, the plugin will determine the app ID by the PID of the top-level parent process (which corresponds to the currently used terminal emulator) when using any terminal besides iTerm or Apple Terminal. This enables basic plugin functionality, such as determining if the terminal emulator is in focus, sending notifications, and navigating the user back to the terminal after they press "Show" button inside notification.