Fixes Mac Catalyst build with bumped OS minimum requirements #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your reasoning is sound. @Coeur any thoughts? We do support back to 10.15 on the base macOS. I'm assuming that Catalyst maps to the Mac versions of libraries and not any iOS ones tied to equivalent iOS version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an explicit Mac Catalyst deployment target to match the macOS target, the prior minimum OS version bump breaks the build for Catalyst apps targeting macOS 10.15 and macOS 11 (which I guess are already covered by the security patch for CVE-2018-25032?). Mac apps generally need to target further back than the latest OS.
Could make sense to increase this from
.macCatalyst("13.0")to a higher point release to be sure. Thoughts?