Improved returned errors #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Re-wired ErrScanTimout which was left unused since prior code changes
- Added ErrScanInterrupt which is now returned on ctrl+c or programmatically triggered interrupts (cancelled contexts). This is useful to distinguish interrupt exit codes from others during error handling.
- Introduced ErrScanInterrupt which is returned on ctrl+c or programmatically triggered interrupts (cancelled contexts). This is useful to distinguish interrupt exit codes from others during error handling.
Ullaakut
reviewed
May 22, 2025
Co-authored-by: Brendan Le Glaunec <brendan@glaulabs.com>
Co-authored-by: Brendan Le Glaunec <brendan@glaulabs.com>
Cleaned up code changes
Ullaakut
approved these changes
May 23, 2025
|
I think both was working, but your suggestion is cleaner and also matches the style used in other areas. I've updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.