Hp calc #4
Open
Hp calc #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The calculation is wrong
…On Fri, Oct 19, 2018, 11:33 Olle Kelderman ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
- add intellij stuff to gitignore
- add hp calc
File Changes
- *M* osuApiConnector/.gitignore
<https://github.com/Tillerino/osuApiConnector/pull/4/files#diff-0> (4)
- *M*
osuApiConnector/src/main/java/org/tillerino/osuApiModel/OsuApiBeatmap.java
<https://github.com/Tillerino/osuApiConnector/pull/4/files#diff-1>
(15)
Patch Links:
- https://github.com/Tillerino/osuApiConnector/pull/4.patch
- https://github.com/Tillerino/osuApiConnector/pull/4.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL9Zd2olp6lFUuq-mlhDsPDbyV3DKDEks5umZx4gaJpZM4XwAV1>
.
|
|
welp, @ThePooN told me to use https://github.com/ThePooN/osu-ModPropertiesCalculator/blob/master/index.js so I did xD |
|
I think a unit test or two would go a long way in convincing me.
…On Fri, Oct 19, 2018, 15:26 Olle Kelderman ***@***.***> wrote:
welp, @ThePooN <https://github.com/ThePooN> told me to use
https://github.com/ThePooN/osu-ModPropertiesCalculator/blob/master/index.js
so I did xD
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL9ZScdj5lHHDZtB6RJTlRUvMAFXm8Lks5umdMXgaJpZM4XwAV1>
.
|
|
well tbf, I have no freakin clue myself, so I wouldnt know where to pull testdata from... I can write unit tests sure, but I have no idea what data to test against. I'm just working on assumptions poon told me ¯\(ツ)/¯ |
|
Just use values that the game gives you to test against? |
|
i'll try to wip up something when im home today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.