Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve codebase and other changes #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheRealKeto
Copy link
@TheRealKeto TheRealKeto commented Feb 20, 2022

The following changes were made

  • Use f-strings over object + "string": don't do this
  • Remove Python byte-compiled code; it's ignored by Git now
  • Remove useless requirements: they're already part of Python!
  • Improve PackageLister: use Path over os module

Also, the repo should be labeled as a template

Signed-off-by: TheRealKeto <therealketo@gmail.com>
Signed-off-by: TheRealKeto <therealketo@gmail.com>
Signed-off-by: TheRealKeto <therealketo@gmail.com>
Signed-off-by: TheRealKeto <therealketo@gmail.com>
Signed-off-by: TheRealKeto <therealketo@gmail.com>
@Shugabuga
Copy link
Owner

I would have to do regression testing but this look sound.

Silica was written ages ago by now and I have definitely grown since then. As for the future of Silica as a tool, CI/CD is something I do want to look into, as is better integrations into Actions for Pages deploys, because that's now a thing! But also, jailbreaking is on the decline, so I do have to triage whether there still is demand (I am thinking to resume maintenance, based on its popularity).

As for whether this should be a template repo: I lean on "no" because Silica is ultimately a tool, not a template. It's philosophically more related to create-react-app and Jekyll than traditional boilerplates (especially other repo templates).


For those wondering why I've been AWOL: tl;dr is university.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants