Fix issue https://github.com/Seldaek/monolog/issues/1984 #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should include a non-regression test with your patch, in RotatingFileHandlerTest. |
I won't prepare any tests because:
We need this fix, because this error produce many warnings in our project. |
jmikola
reviewed
Oct 17, 2025
| // are cleaning up/rotating at the same time | ||
| set_error_handler(function (int $errno, string $errstr, string $errfile, int $errline): bool { | ||
| return false; | ||
| return true; |
There was a problem hiding this comment.
I left a related comment in #1984 (comment), but I think this is a fix for a bug that inadvertently introduced when return types were added across the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1984