Allow DerivePartialModel to have nested aliases #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same model in the model.
…e same model in the model #2639
tyt2y3
commented
Aug 9, 2025
tyt2y3
commented
Aug 9, 2025
tyt2y3
added a commit
that referenced
this pull request
Aug 9, 2025
* feta: Allow DerivePartialModel to add nested aliases and associate the same model in the model. * fix left behind trailing whitespace. * Add partial_model_nested_alias test case. * Fmt * Use fully qualified syntax on into_expr * Fix * Fix the order of creating tables * Clean up * Refactor * Remove unnecessary code * Merge .rustfmt.toml and rustfmt.toml * rename --------- Co-authored-by: silence <silence.zpk@gmail.com> Co-authored-by: Huliiiii <134658521+Huliiiiii@users.noreply.github.com>
🎉 Released In 1.1.15 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution attaches the alias definition to the nested model, which is not very flexible.
Defining it in the parent model is the better way.
We only need to fix / rewrite the test cases