-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Request: Rougier #28
Conversation
Yes, I'll take over the EIC role for this submission! @ThomasA can you supervise the reviewing process? |
Yes 👍 |
Hi, Sorry this is outside my expertise. |
@soolijoo OK, I will try someone else. |
@almarklein can you review this replication? |
Sure! Is this ready for review at this point? |
@rougier I am stuck trying to build the PDF. I cannot use the 'fontawesome' package on my system. XeLaTeX seems to try to call some font-generating stuff that fails. I have TeXlive 2016 installed in Ubuntu (installed directly from TexLive - not Ubuntu repositories). The fontawesome package is installed, but somehow not useable. |
@rougier if I comment out
|
rescience-template.tex was updated from ReScience/ReScience-submission.
If you compile using directly the latex command, what is the output ? |
For the fontawesome installation, what is the error in the font generating stuff ? |
@rougier By the way, I just by mistake pushed some updates to your repo. Now I do not understand how I actually had the permission to do so? I guess this is not a major problem - the updates are supposed to go in the archive repo anyway. |
Regarding fonawesome, making the paper says:
I am whining about it here as well: https://tex.stackexchange.com/questions/369068/how-can-i-use-the-fontawesome-package-with-xelatex |
Yes, I can see your changes in my repo. That's totally weird. |
Just to be sure, you've also installed the |
Yes, it is in the Texlive tree |
Oh, the font is bundled with the tex package ? |
Yes, fontawesome is included in Texlive. I am getting some help here: https://tex.stackexchange.com/questions/369068/how-can-i-use-the-fontawesome-package-with-xelatex, but none of it seems to work... |
OK, I finally made it work. |
I have been looking at this: https://tex.stackexchange.com/questions/193412/what-is-happening-to-the-quotes and this: https://tex.stackexchange.com/questions/278251/ligatures-stopped-working-in-xelatex. |
Should we simply ignore that |
Could you make a PR for the main rescience-template and fix it on this repo then ? |
Sorry, I got stuck last week trying to compile the paper for publishing. This week I am swamped with a course I am giving. I hope to pick this back up tomorrow or during the weekend. |
@ThomasA Any chance to publish it this week ? |
@ThomasA a gentle reminder... |
Sorry, I will try to do it tomorrow evening. These days are packed with
teaching and conducting exams tomorrow...
|
@rougier could you please rebuild the PDF on rougier/ReScience-submission on your rougier-2017 branch (including the changes it turned out I was able to push to your repo)? I have no XeTeX experience and seem unable to get the fonts set up correctly on my system to make it compile. |
Done. |
EDITOR This submission has been published and will soon appear at http://rescience.github.io/read/ |
This looks good! Thanks to @ThomasA for handling the review, to @rth and @almarklein for reviewing, and to @rougier for doing the replication work! |
AUTHOR
Dear @ReScience/editors,
I request a review for the following replication:
Original article
Title: Weighted Voronoi Stippling
Author(s): Adrian Secord
Journal (or Conference): International Symposium on Non-photorealistic Animation and
Rendering
Year: 2002
DOI: 10.1145/508530.508537
PDF: http://mrl.nyu.edu/~ajsecord/npar2002/npar2002_ajsecord_preprint.pdf
Replication
Author(s): Nicolas P. Rougier
Repository: https://github.com/rougier/ReScience-submission/tree/rougier-2017
PDF: https://github.com/rougier/ReScience-submission/blob/rougier-2017/article/Rougier-2017.pdf
Keywords: Python, Stippling, Voronoi, Computer Graphics, Blue Noise
Language: Python
Domain: Signal Processing
Results
Potential reviewers
EDITOR
February 27, 2017
February 28, 2017
February 27, 2017
April 19, 2017
April 28, 2017
May 9, 2017