Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing spelling errors in rasa-sdk #833

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoaoP-Coelho
Copy link
@JoaoP-Coelho JoaoP-Coelho commented Aug 16, 2022

Proposed changes:

  • succesfully -> successfully
  • overriden -> overridden
  • versionned -> versioned
  • paramer -> parameter
  • insteaad -> instead
  • shoudn't -> shouldn't

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link
CLAassistant commented Aug 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member
@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯
Could you please add a changelog entry of type misc to document the typo corrections?

@JoaoP-Coelho
Copy link
Author

@ancalita Done, sorry for the long wait, but i created the changelog!

@@ -70,7 +70,7 @@ def __init__(
@property
def active_form(self) -> Dict[Text, Any]:
warnings.warn(
Copy link
Member
@ancalita ancalita Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter check failed on line 71 because it expected a docstring, could you please add the following docstring:

Returns the active_loop dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants