Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ui-test #27

Merged
merged 13 commits into from
Jun 26, 2023
Merged

Add a ui-test #27

merged 13 commits into from
Jun 26, 2023

Conversation

martinRenou
Copy link
Member

Fix #9

@martinRenou
Copy link
Member Author

please update playwright snapshots

@github-actions
Copy link

Binder 👈 Launch a Binder on branch martinRenou/glue-lab/ui-tests

@martinRenou
Copy link
Member Author

Bot running in https://github.com/QuantStack/glue-lab/actions/runs/4701308885

@martinRenou martinRenou force-pushed the ui-tests branch 4 times, most recently from 844bf6d to e2b5a9a Compare April 18, 2023 08:02
@martinRenou
Copy link
Member Author

Tests are too flaky... With bqplot taking ages to render properly and readjust its layout.

@martinRenou
Copy link
Member Author
martinRenou commented Jun 21, 2023 •
edited
Loading

I start to feel like tests are flaky because of gridstack, not bqplot. We've had stable UI testing in bqplot for a couple of years now and no issue, and hiding the bqplot figures from the viewers does not fix the flakiness.

@martinRenou martinRenou force-pushed the ui-tests branch 2 times, most recently from 24a2dd0 to 498782a Compare June 23, 2023 15:55
@trungleduc trungleduc force-pushed the ui-tests branch 2 times, most recently from 60cc10f to 5de665a Compare June 26, 2023 11:24
@trungleduc
Copy link
Member

please update playwright snapshots

@trungleduc trungleduc force-pushed the ui-tests branch 2 times, most recently from 5a45a0b to ecc31da Compare June 26, 2023 11:58
@trungleduc trungleduc marked this pull request as ready for review June 26, 2023 14:45
@martinRenou
Copy link
Member Author

Thanks a lot!!

@martinRenou martinRenou merged commit a538f01 into QuantStack:main Jun 26, 2023
@martinRenou martinRenou deleted the ui-tests branch June 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui-tests with playwright
2 participants
@martinRenou @trungleduc