New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle callable `from_users` for `NewMessage` events #4456

Open

mehdiirh wants to merge 1 commit into LonamiWebs:v1 from mehdiirh:callable_from_users

mehdiirh commented

No description provided.


          Handle callable from_users for NewMessage events

3a5e035

Member

Lonami commented

I'd prefer to avoid new features in v1. What would be the use case for this?

Author

mehdiirh commented

Hi
Retrieving eligible users dynamically from the database, instead of hard coding them. like admins

Member

Lonami commented

Why not make the call directly? This PR doesn't support async, and after it's set, if it changes later, it won't re-fetch them either.

Lonami force-pushed the v1 branch from 925f5e8 to f652f3f Compare

September 23, 2024 17:01

xximwon approved these changes

View reviewed changes

xximwon approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet