Deprecate conflicts_with formula: in Cask DSL.
#20499
Conversation
3e100f3 to
0c6ca3a
Compare
0c6ca3a to
addde1c
Compare
|
@Rylan12 Thanks! I think it's fine as-is in case anyone wants to actually implement the other elements. |
This is outside of our usual deprecation process but it's a no-op method that does, and has always done, nothing so it doesn't make sense to wait another 2.5 months before deprecating it. While we're here, make `conflicts_with` `typed: strict` in Sorbet.
addde1c to
d13aaf9
Compare
|
Just saw this while updating — potentially related? |
|
Yeah, also seeing this randomly when running commands, but haven't pinned down a reliable repro. |
|
FTR, I got this on After spending a while investigating it (and finding both this PR and the cleanup in Homebrew/homebrew-cask#224407), it no longer repeats when I try My guess is that either (a) the local cache or (b) the API feed hadn't quite updated before the "remove support for..." code update was merged. But after the errror run, the next run did have fresh metadata. While the rationale for not waiting 2.5 months makes sense, it might have made sense to leave, eg, a week between removing the last references and removing support for If nothing else, it might have reduced confusion over a "how did we get here?` error :-) Ewen |
|
It seems like the issue here is that the Caskfiles in these isntances in Replicated locally with |
refs Homebrew/brew#20499 refs https://github.com/orgs/goreleaser/discussions/5995 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
Let's continue discussion in the issue: #20516 |
This is outside of our usual deprecation process but it's a no-op method that does, and has always done, nothing so it doesn't make sense to wait another 2.5 months before deprecating it.
While we're here, make
conflicts_withtyped: strictin Sorbet.Fixes #16398