Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DS::Stream::readLine for files without a trailing newline #192

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix DS::Stream::readLine for files without a trailing newline #192

merged 1 commit into from
Feb 23, 2024

Conversation

dgelessus
Copy link
Contributor

As is currently the case for some SDL files in the H'uru/Plasma repo.

This fixes some [SDL] Unexpected EOF errors/warnings (?) on startup.

zrax
zrax reviewed Feb 23, 2024
View reviewed changes
streams.cpp Outdated Show resolved Hide resolved
@dgelessus
Fix DS::Stream::readLine for files without a trailing newline
83b41c7 
As is currently the case for some SDL files in the H'uru/Plasma repo.
@dgelessus dgelessus force-pushed the fix_readline_when_no_trailing_newline branch from a8858b5 to 83b41c7 Compare February 23, 2024 18:07
@zrax zrax merged commit 78a71c9 into H-uru:master Feb 23, 2024
4 checks passed
@dgelessus dgelessus deleted the fix_readline_when_no_trailing_newline branch February 23, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas approved these changes

@zrax zrax zrax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgelessus @zrax @Hoikas