fix TalkerScreen does not respect configured LogLevel setting #168 #300

mylukin · 2024-12-27T05:35:57Z

I solved this issue #168

Frezyx

@mylukin hello! Thank you for this PR 👍🏻
Please remove last commit. If you want to implement LogLevel for TalkerDioLoggerSettings - create separated Pull Request

mylukin · 2024-12-28T07:17:33Z

ok, I removed last commit.
thank you!

codecov-commenter · 2024-12-28T09:00:16Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (f2fd7f8) to head (9250fce).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   98.39%   96.92%   -1.47%     
==========================================
  Files          28       19       -9     
  Lines         560      293     -267     
==========================================
- Hits          551      284     -267     
  Misses          9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Frezyx · 2024-12-28T09:02:30Z

@mylukin Everything is good and we ready to merge.
But filter getter in TalkerLogger must be covered by tests before we merge this PR

Codecov link

add test case

fix TalkerScreen does not respect configured LogLevel setting Frezyx#168

b298b06

Frezyx added bugfix Bug fixes talker_flutter Related to talker_flutter package labels Dec 27, 2024

Frezyx linked an issue Dec 27, 2024 that may be closed by this pull request

TalkerScreen does not respect configured LogLevel setting #168

Closed

Frezyx requested changes Dec 28, 2024

View reviewed changes

mylukin force-pushed the master branch from 1a312e1 to b298b06 Compare December 28, 2024 07:16

mylukin deleted the branch Frezyx:master December 28, 2024 07:19

mylukin closed this Dec 28, 2024

mylukin deleted the master branch December 28, 2024 07:19

mylukin reopened this Dec 28, 2024

mylukin force-pushed the master branch from 1a312e1 to b298b06 Compare December 28, 2024 07:24

Frezyx approved these changes Dec 28, 2024

View reviewed changes

mylukin and others added 5 commits December 29, 2024 11:59

add test case

59c85bf

Merge pull request #1 from mylukin/fixbug_for_TalkerScreen

7e9b474

add test case

Fix analyzer issues

e2d7007

Revert Flutter 3.27 analyzer issue

9250fce

Release v4.5.5

fc8794a

Frezyx merged commit ba5106a into Frezyx:master Dec 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix TalkerScreen does not respect configured LogLevel setting #168 #300

fix TalkerScreen does not respect configured LogLevel setting #168 #300

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix TalkerScreen does not respect configured LogLevel setting #168 #300

fix TalkerScreen does not respect configured LogLevel setting #168 #300

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants