riverpod 3.0.0 support #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR upgrades the package to Riverpod 3.0.0 by migrating the test suite to the new Notifier and ProviderContainer.test APIs, refactoring the observer and log classes to use the updated ProviderObserverContext signatures, and bumping dependency versions and imports across pubspecs and source files. Class diagram for ProviderObserverContext usage in observer methodsclassDiagram
class ProviderObserverContext {
+ ProviderBase<Object?> provider
// Other context fields (not shown)
}
class TalkerRiverpodObserver {
+ didAddProvider(ProviderObserverContext context, Object? value)
+ didUpdateProvider(ProviderObserverContext context, Object? previousValue, Object? newValue)
+ didDisposeProvider(ProviderObserverContext context)
+ providerDidFail(ProviderObserverContext context, Object error, StackTrace stackTrace)
}
TalkerRiverpodObserver --> ProviderObserverContext
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `packages/talker_riverpod_logger/lib/talker_riverpod_logger_observer.dart:35` </location>
<code_context>
+
+ if (!settings.enabled || !settings.printProviderAdded) return;
+
+ final accepted = settings.providerFilter?.call(context.provider) ?? true;
+ if (!accepted) return;
+
_talker.logCustom(
</code_context>
<issue_to_address>
Provider filter logic is duplicated across methods.
Extract the provider filter logic into a shared helper to avoid repetition and improve maintainability.
Suggested implementation:
```
bool _isProviderAccepted(ProviderBase provider) {
return settings.providerFilter?.call(provider) ?? true;
}
void didAddProvider(ProviderObserverContext context, Object? value) {
super.didAddProvider(context, value);
if (!settings.enabled || !settings.printProviderAdded) return;
if (!_isProviderAccepted(context.provider)) return;
_talker.logCustom(
RiverpodAddLog(
provider: context.provider,
value: value,
settings: settings,
),
```
You should also update other methods in this file (such as `didUpdateProvider`, `didDisposeProvider`, etc.) that use the provider filter logic to use the new `_isProviderAccepted` helper for consistency and maintainability.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
packages/talker_riverpod_logger/lib/talker_riverpod_logger_observer.dart
Show resolved
Hide resolved
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
===========================================
+ Coverage 98.63% 100.00% +1.36%
===========================================
Files 3 3
Lines 146 77 -69
===========================================
- Hits 144 77 -67
+ Misses 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
done! looks like this PR is ready to merged, whenever, unless you have something to say about it @Frezyx |
|
up |
DmitrySboychakov
suggested changes
Sep 17, 2025
|
Hello 👋🏼 @Frezyx sorry for pinging you, but I'd really love to see |
|
Looking forward for this one. |
down to `^1.15.0`
DmitrySboychakov
approved these changes
Oct 8, 2025
Frezyx
approved these changes
Oct 9, 2025
|
Hello @lucavenir ! Now 5.0.2 version is available for download on pub |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riverpod 3.0 is out!
this fixes #424
Summary by Sourcery
Migrate the package to Riverpod 3.0 by updating observer interfaces, provider APIs, imports, and test code, and bump dependency constraints accordingly.
New Features:
Enhancements:
Tests: