introduce multi-path configuration #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: - sometimes you might have more than one healthcheck, eg. in Kubernetes we have readiness / liveliness checks solution: - extend the api to accept list of paths to ignore + tests
amencarini
reviewed
Jul 16, 2018
lib/plug/quiet_logger.ex
Outdated
| end | ||
|
|
||
| def call(%{request_path: path} = conn, %{log: :info, path: paths}) when is_list(paths) do | ||
| cond do |
There was a problem hiding this comment.
I normally prefer an if statement instead of a binary cond, it feels a bit clearer!
if path in paths, do: conn, else: Plug.Logger.call(conn, log)
What do you think?
lib/plug/quiet_logger.ex
Outdated
| %{log: log, path: path} | ||
| end | ||
|
|
||
| def call(%{request_path: path} = conn, %{log: :info, path: paths}) when is_list(paths) do |
There was a problem hiding this comment.
The hardcoded :info would prevent the configurability of the log level. Is that intended?
lib/plug/quiet_logger.ex
Outdated
| true -> Plug.Logger.call(conn, :info) | ||
| end | ||
|
|
||
| conn |
There was a problem hiding this comment.
You don't need this at the end of the function, you can safely rely on what's returned from the previous cond/if statement 🙂
|
@amencarini thanks for the feedback, looks cleaner now! |
|
Amazing, thank you so much, will push to hex momentarily 🌈 |
|
Thank you!
…On Tue, Jul 24, 2018, 2:44 PM Alessandro Mencarini ***@***.***> wrote:
Amazing, thank you so much, will push to hex momentarily 🌈
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAE0Lo9RwW8UP13gXA2T2RefJyoOveXks5uJxaqgaJpZM4VROo0>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
solution: