RUM-7484 Add placeholder for unknown SwiftUI content #2155

maxep · 2024-12-18T14:55:43Z

How?

Return placeholder wireframe when an unknown SwiftUI content is encountered.

Review checklist

Feature or bugfix MUST have appropriate tests (unit, integration)
Make sure each commit and the PR mention the Issue number or JIRA reference
Add CHANGELOG entry for user facing changes
Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

datadog-datadog-prod-us1 · 2024-12-18T15:13:29Z

Datadog Report

Branch report: maxep/RUM-7484/swiftui-placeholder
Commit report: 3780aec
Test service: dd-sdk-ios

✅ 0 Failed, 29 Passed, 3581 Skipped, 15.45s Total duration (2m 15.97s time saved)

maxep · 2024-12-18T16:52:59Z

/merge

dd-devflow · 2024-12-18T16:53:14Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-18 16:53:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-18 17:34:26 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

maxep · 2024-12-18T17:34:20Z

/remove

dd-devflow · 2024-12-18T17:34:25Z

Devflow running: `/remove`

View all feedbacks in Devflow UI.

2024-12-18 17:34:24 UTC ℹ️ Devflow: /remove

maxep · 2024-12-18T18:31:02Z

/merge

dd-devflow · 2024-12-18T18:31:19Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-18 18:31:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-18 19:04:46 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in develop is 28m.

2024-12-18 19:31:40 UTC ℹ️ MergeQueue: This merge request was merged

msrutek-paylocity · 2025-01-02T15:03:50Z

...eSnapshotProducer/ViewTreeSnapshot/NodeRecorders/SwiftUI/SwiftUIWireframesBuilderTests.swift

+@testable import DatadogSessionReplay
+
+@available(iOS 13.0, tvOS 13.0, *)
+class SwiftUIWireframesBuilderTests: XCTestCase {


maxep requested review from a team as code owners December 18, 2024 14:55

mariedm previously approved these changes Dec 18, 2024

View reviewed changes

maxep dismissed mariedm’s stale review via c338f34 December 18, 2024 16:45

maxep force-pushed the maxep/RUM-7484/swiftui-placeholder branch from 69a0d61 to c338f34 Compare December 18, 2024 16:45

mariedm approved these changes Dec 18, 2024

View reviewed changes

dd-devflow bot added the mergequeue-status: waiting label Dec 18, 2024

dd-devflow bot removed the mergequeue-status: waiting label Dec 18, 2024

dd-devflow bot added the mergequeue-status: removed label Dec 18, 2024

RUM-7484 Add placeholder for unknown SwiftUI content

3780aec

maxep force-pushed the maxep/RUM-7484/swiftui-placeholder branch from c338f34 to 3780aec Compare December 18, 2024 18:30

dd-devflow bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: removed mergequeue-status: waiting mergequeue-status: queued labels Dec 18, 2024

dd-mergequeue bot merged commit 92ef71f into develop Dec 18, 2024
16 checks passed

dd-devflow bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Dec 18, 2024

mariedm deleted the maxep/RUM-7484/swiftui-placeholder branch December 19, 2024 08:01

maciejburda mentioned this pull request Jan 2, 2025

Release 2.22.0 #2157

Merged

4 tasks

msrutek-paylocity reviewed Jan 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RUM-7484 Add placeholder for unknown SwiftUI content #2155

RUM-7484 Add placeholder for unknown SwiftUI content #2155

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RUM-7484 Add placeholder for unknown SwiftUI content #2155

RUM-7484 Add placeholder for unknown SwiftUI content #2155

Uh oh!

Conversation

How?

Review checklist

Uh oh!

Uh oh!

Datadog Report

Uh oh!

Uh oh!

Uh oh!

Devflow running: /merge

Uh oh!

Uh oh!

Devflow running: /remove

Uh oh!

Uh oh!

Uh oh!

Devflow running: /merge

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Devflow running: `/merge`

Devflow running: `/remove`

Devflow running: `/merge`