Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async not awaited #484

Merged
merged 12 commits into from
Dec 14, 2024
Merged

Fix async not awaited #484

merged 12 commits into from
Dec 14, 2024

Conversation

webfiltered
Copy link
Contributor

Clean up - Part II

  • Based on [Refactor] Improve separation of concerns / lifecycle #482
  • Fixes most unawaited async calls
    • Remaining unhandled promises are inside synchronous callbacks
    • One solution is to just catch & report errors via API to frontend
  • Fixes use of async callbacks in functions that do not support async

@webfiltered webfiltered requested a review from a team as a code owner December 14, 2024 17:21
@webfiltered webfiltered mentioned this pull request Dec 14, 2024
Merged
huchenlei
huchenlei approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member
@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei merged commit 5c55ed8 into main Dec 14, 2024
7 checks passed
@huchenlei huchenlei deleted the fix-await branch December 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei