Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git download & install to install scripts #379

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add git download & install to install scripts #379

wants to merge 4 commits into from
+121 −22

Conversation

webfiltered
Copy link
Contributor
@webfiltered webfiltered commented Nov 27, 2024 •
edited by sync-by-unito bot
Loading
  • Downloads and installs git if not present
    • Requires testing

┆Issue is synchronized with this Notion page by Unito

@webfiltered
Copy link
Contributor Author

I can't test the interop with beforeInstall.js, or what working dirs are used during install phases. Confidence in the NSIS install.nsh script is reasonably high.

@robinjhuang
Copy link
Member

If you run Publish All on this branch you can create a build in todesktop. Can we test that before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjhuang robinjhuang Awaiting requested review from robinjhuang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @robinjhuang