Use the project-level swift version when not defined at the target-level #5760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM when CI Passes - Out of interest in what cases does Xcode generate these? |
|
If you set "Use Legacy Swift Language Version" to Yes or No in the Project then you get this. |
|
If by "generate" you mean the |
|
The caveat here though is that if you only configure "Use Legacy Swift Language Version" in the project and not in the targets, then you won't run into any issues because the |
|
@benasher44 makes sense |
|
Only failure is the spurious |
|
|
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5737 and #5700
PodVariants are unique by, among other things, theirTargetDefinition's swift version. Previously this would benilif only defined at the project level. This would lead to multiplePodVariantinstances for the samePodTargetincorrectly, and later on this leads to theErrno::EEXISTerrors from incorrectly trying to create the same support files directories for the samePodTargets.