Fix Segmentation Fault 11 while calling FetchCache.updateLastFetchTime #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to have this to be merged. My github action failed 100% now because of this |
jonbrooks
reviewed
Dec 13, 2019
| private static let lock< 8000 /span> = NSLock() | ||
|
|
||
| internal static func clearFetchTimes() { | ||
| lastFetchTimes.removeAll() |
There was a problem hiding this comment.
If the lock is guarding usage of lastFetchTimes, do we need the lock here as well?
There was a problem hiding this comment.
As you pointed out, it needed to be added!
canius
approved these changes
Jan 6, 2020
jonbrooks
approved these changes
Jan 31, 2020
8000
|
Hi @taisukeh do you plan to merge this soon? Our builds are failing too frequently, would like to try out this fix. thank you! |
|
Our bitrise builds are plagued with above issue. Can we get a release with the above fix? |
|
tbh, i added this workaround a few months ago and it's been fine 😄
|
markshiz
pushed a commit
to knowink-dev/Carthage
that referenced
this pull request
Mar 12, 2020
Carthage#2908) * Use NSLock in FetchCache methods * Add lock to clearFetchTimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#2760 (comment)
Solution
Use NSLock to coordinates the operation of multiple threads of execution within the FetchCache.