Backends: sign generated file with BNFC's version number #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2f7a4a
to
99aef5c
Compare
Printing "generated by BNFC" is now taking place uniformly in Backend.Base, rather than in the individual backends. The backends need to supply a comment-creating function to @mkfile@. The BNFC-signature includes now BNFC's version number. .txt files are signed at the end since txt2tags treats the first lines special (as headings). Otoh, JLex only accepts comments at the beginning (the Java preamble). So, the default remains to sign at the beginning, which is also more customary.
99aef5c
to
fe0b17b
Compare
andreasabel
added a commit
that referenced
this pull request
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing "generated by BNFC" is now taking place uniformly in
Backend.Base, rather than in the individual backends.The backends need to supply a comment-creating function to
mkfile.The BNFC-signature includes now BNFC's version number.
.txtfiles are signed at the end sincetxt2tagstreats the first lines special (as headings).Otoh,
JLexonly accepts comments at the beginning (the Java preamble).So, the default remains to sign at the beginning, which is also more customary.