[C] Emit correct function prototypes #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects the generated file Absyn.h.
Example before:
Full_combinator_id make_AbsentFCID();
Example after:
Full_combinator_id make_AbsentFCID(void);
This change is required as "make_AbsentFCID()" in C actually
means "takes an arbitrary amount of arguments", which is not
the desired semantics.
gdetrez
added a commit
that referenced
this pull request
Sep 9, 2016
gdetrez
added a commit
that referenced
this pull request
Sep 9, 2016
Set CCFLAGS to -Werro -Wstrict-prototypes so that gcc fails in case a function is declared or defined without specifying the argument types. This serves as a regression test for pull request #185.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the generated file
Absyn.h.Example before:
Example after:
This change is required as
make_AbsentFCID()in C actuallymeans "takes an arbitrary amount of arguments", which is not
the desired semantics.
make testpasses all suites. Someone should probably write a regression test for this, so this bug isn't introduced again.