Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haskell: local variables in Printer may clash with printing functions #337

Closed
andreasabel opened this issue Jan 31, 2021 · 1 comment
Closed

Haskell: local variables in Printer may clash with printing functions #337

andreasabel opened this issue Jan 31, 2021 · 1 comment
Assignees
@andreasabel
Labels
bug Haskell printer Concerning the generated printer
Milestone
2.9.1

Comments

@andreasabel
Copy link
Member 
M. Main ::= Prt;
P. Prt  ::= Integer;

The generated printer does not compile:

[4 of 6] Compiling PrintTest        ( PrintTest.hs, PrintTest.o )

PrintTest.hs:110:43: error:
    • Couldn't match expected type ‘t0 -> AbsTest.Prt -> Doc’
                  with actual type ‘AbsTest.Prt’
    • The function ‘prt’ is applied to two arguments,
      but its type ‘AbsTest.Prt’ has none
      In the expression: prt 0 prt
      In the first argument of ‘concatD’, namely ‘[prt 0 prt]’
    |
110 |     AbsTest.M prt -> prPrec i 0 (concatD [prt 0 prt])
    |                                           ^^^^^^^^^

The problem is that the constructor arguments are lowercase versions of the argument types, e.g. Prt gives prt, which is the name of the printing function.

A solution is to prefix the local variables with an underscore.
@andreasabel andreasabel added bug Haskell printer Concerning the generated printer labels Jan 31, 2021
@andreasabel andreasabel added this to the 2.9.1 milestone Jan 31, 2021
@andreasabel andreasabel self-assigned this Jan 31, 2021
andreasabel added a commit that referenced this issue Jan 31, 2021
@andreasabel
[ re #337 ] Haskell: use \case in Print.hs
a5cd860
@andreasabel
Copy link
Member Author

A solution is to prefix the local variables with an underscore.

There was also a list of names to avoid, I added prt and doc.

@andreasabel andreasabel mentioned this issue Jan 31, 2021
Closed
9 tasks
andreasabel added a commit that referenced this issue Feb 27, 2021
@andreasabel
[ #337 ] XML printer: avoid clashes with "prt"
3a93c9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
bug Haskell printer Concerning the generated printer
Projects
None yet
Milestone
2.9.1
Development

No branches or pull requests
1 participant
@andreasabel