Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haskell printer generator should not use deprecated OverlappingInstances extension #233

Closed
andreasabel opened this issue Sep 25, 2018 · 1 comment
Closed

Haskell printer generator should not use deprecated OverlappingInstances extension #233

andreasabel opened this issue Sep 25, 2018 · 1 comment
Assignees
@andreasabel
Labels
ghc-8.4 Haskell
Milestone
2.8.3

Comments

@andreasabel
Copy link
Member

Haskell printer generator should not use the deprecated OverlappingInstances extension on recent GHCs. E.g., on ghc-8.2:

CPP/Print.hs:1:33: warning:
   -XOverlappingInstances is deprecated: instead use per-instance pragmas OVERLAPPING/OVERLAPPABLE/OVERLAPS
 |
1 | {-# LANGUAGE FlexibleInstances, OverlappingInstances #-}
 |                                 ^^^^^^^^^^^^^^^^^^^^

For backwards compatiblity, we could use #if pragmas.

From ghc-8.6 on, OverlappingInstances may trigger an error.
@andreasabel andreasabel added this to the 2.8.2 milestone Sep 25, 2018
@andreasabel andreasabel mentioned this issue Sep 25, 2018
Closed
5 tasks
@andreasabel andreasabel modified the milestones: 2.8.2, 2.8.3 Nov 4, 2018
@andreasabel andreasabel self-assigned this Feb 3, 2019
@andreasabel
Copy link
Member Author

I am changing the Haskell backend to use the {-# OVERLAPPABLE #-} pragma.
As a consequence, BNFC-2.8.3 will only work for GHC >= 7.10.

andreasabel added a commit that referenced this issue Feb 3, 2019
@andreasabel
[ #233 ] Retain compatibility with GHC 7.6
bf5a452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
ghc-8.4 Haskell
Projects
None yet
Milestone
2.8.3
Development

No branches or pull requests
1 participant
@andreasabel