Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String rendering in Java does not work #159

Closed
gapag opened this issue Nov 19, 2015 · 4 comments
Closed

String rendering in Java does not work #159

gapag opened this issue Nov 19, 2015 · 4 comments
Assignees
@gdetrez
Labels
bug Java
Milestone
2.8.2

Comments

@gapag
Copy link
gapag commented Nov 19, 2015

BNFC 2.8.
Consider grammar

One . BugOne ::= "the_following_is_a_quoted_string" String;

run

bnfc --java -m quotebug.cf
make

then

java quotebug.Test < input

where input 's content is

the_following_is_a_quoted_string "here I am"

Output is

Parse Succesful!

[Abstract Syntax]

(One "here I am") 

[Linearized Tree]

the_following_is_a_quoted_string here I am

but last line should be

the_following_is_a_quoted_string "here I am"
gapag pushed a commit to gapag/bnfc that referenced this issue Nov 19, 2015
Fix String rendering in Java does not work (BNFC#159)
4008c8b
gapag pushed a commit to gapag/bnfc that referenced this issue Nov 20, 2015
Fix TokenCat in prList (BNFC#159); make lexer more flexible
fe86d45
@gdetrez
Copy link
Contributor
gdetrez commented Feb 4, 2016

Can you open a PR with your fix?

@gapag
Copy link
Author
gapag commented Feb 4, 2016

The commit is within the big pull #155, the 4008c8b above
Or do you want me to make another pull request explicitly?

The other commit fe86d45 is on a branch of mine that cannot be merged painlessly...

@gdetrez
Copy link
Contributor
gdetrez commented Feb 5, 2016

Hum, no, I didn't realize it was already merged :-) Does that mean we can close this issue?

@gapag
Copy link
Author
gapag commented Feb 12, 2016

Tested manually on 843075e with the example above, success. To be on the safe side, could you add the example above to the regression-tests and then close the issue?

@gdetrez gdetrez self-assigned this Feb 13, 2016
@gdetrez gdetrez modified the milestone: 2.9 Sep 7, 2016
@gdetrez gdetrez closed this as completed in b5ad016 Nov 4, 2016
gdetrez added a commit that referenced this issue Nov 4, 2016
@gdetrez
[#159] Add regression test
164f0cc 
Close #159
@andreasabel andreasabel modified the milestones: 2.9, 2.8.1, 2.8.2 Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdetrez gdetrez

Labels
bug Java
Projects
None yet
Milestone
2.8.2
Development

No branches or pull requests
3 participants
@gdetrez @andreasabel @gapag