Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start_linux.sh #62

Closed
wants to merge 1 commit into from
Closed

Update start_linux.sh #62

wants to merge 1 commit into from

Conversation

saeedkhatami
Copy link
Contributor

added auto install dependencies of index.py on linux

added auto install dependencies of index.py
@AlexFlipnote
Copy link
Owner

Don't want people to forcefully install every time

@saeedkhatami
Copy link
Contributor Author

shall I use inputs for installing dependencies?

@ZackeryRSmith
Copy link
Contributor

Don't want people to forcefully install every time

I agree, it also creates a big wall of text (which can be hidden by running pip in silent mode)

You also don't want to ask the user if they want to install dependencies every time they run start_linux.sh, that'd just be irritating! The README goes over how to install the dependencies. No need to have it done in the start script.

@saeedkhatami
Copy link
Contributor Author

ok

@@ -21,7 +21,9 @@ if !command -v python3 &> /dev/null; then
exit
fi

pip3 install -r requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip should be invoked via python3 not using pip3. As pip3 doesn't always point to the correct python install you want to use. Thus, to make sure you are installing the dependencies to the proper location do python3 -m pip install -r requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants