Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine k8s and aks set context #61

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

aamgayle
Copy link

Added aks-set-context's functionality to a function in k8s-set-context along with tests.

@aamgayle aamgayle requested a review from a team as a code owner August 10, 2022 15:36
@aamgayle aamgayle changed the title Asgayle/combine k8s and aks set context asgayle/combine k8s and aks set context Aug 10, 2022
@aamgayle aamgayle changed the title asgayle/combine k8s and aks set context Combine k8s and aks set context Aug 10, 2022
Copy link
Collaborator
@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the rest yet but we need updates to the README.md documentation explaining how to use this.

action.yml Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/run.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Aug 27, 2022
@aamgayle aamgayle removed the idle Inactive for 14 days label Sep 7, 2022
README.md Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Sep 29, 2022
@aamgayle aamgayle removed the idle Inactive for 14 days label Oct 6, 2022
Copy link
Collaborator
@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like all the tests! Things are looking good. Just a slight push to being as simple as possible for users

README.md Outdated Show resolved Hide resolved
src/kubeconfigs/aks.ts Outdated Show resolved Hide resolved
@davidgamero
Copy link
Collaborator

just a heads-up that you will need to sign your commits before merging

Copy link
Collaborator
@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks pretty good to me. Just want to nail the docs side of things

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
jaiveerk
jaiveerk previously approved these changes Oct 14, 2022
Copy link
@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaiveerk
jaiveerk previously approved these changes Oct 17, 2022
jaiveerk
jaiveerk previously approved these changes Oct 17, 2022
@aamgayle aamgayle dismissed stale reviews from OliverMKing and davidgamero October 18, 2022 15:33

Addressed the requested changes

README.md Outdated Show resolved Hide resolved
jaiveerk
jaiveerk previously approved these changes Oct 18, 2022
OliverMKing
OliverMKing previously approved these changes Oct 18, 2022
Copy link
Collaborator
@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Going to wait to merge until I have time to create a release.

aamgayle and others added 24 commits October 18, 2022 15:02
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.6 to 1.9.1.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added the bug report and feature request form

* updated the url
Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](panva/jose@v2.0.5...v2.0.6)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Settling merge conflicts

Moved and refactored aks cluster tests to separate file

Typo fix and removed unused imports

added kubelogin test to utils.test

Reverting changes to action.yml and unused function in util

Removing old tag from integration-tests

Run and run test reversions/refactors

Small run tweaks

Updated README and added method check and tests for AKS cluster

Added Service Account method for aks cluster and updated README

Small README change

Rebase

README change
README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
github-actions bot commented Nov 1, 2022

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants