[17.0][MIG] web_form_banner: Migration to 17.0 #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor JS: - Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields) Miscellaneous improvements: - list view optional - Switch archive box icon to banner Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
- Add (partial) support for elements inside groups to be a target XPath without distorting the presentation - Remove obsolete bits
yostashiro
reviewed
Oct 7, 2025
|
Dynamic banner update seems a bit slower than before. Is there room for improvement? |
da0f0d0 to
2cae18e
Compare
@yostashiro I compared between v16 and v17 in runboat with the latest changes and it is like the same. |
ac600ef to
9883dd7
Compare
yostashiro
approved these changes
Oct 11, 2025
yostashiro
suggested changes
Oct 13, 2025
There was a problem hiding this comment.
There is an issue with banner reload with previous/next button. See #3308 (review).
fad1c14 to
3c6f17f
Compare
yostashiro
approved these changes
Oct 15, 2025
| Should be used instead of <code | ||
| >record</code> when your rule is triggered dynamically by an | ||
| update to a trigger field. It doesn't include any values from complex fields | ||
| (x2many/reference, etc). |
There was a problem hiding this comment.
Minor adjustment.
Suggested change
| (x2many/reference, etc). | |
| (one2many/reference, etc). |
- Fix not updating banner when pager is update or duplicate or create - Fix presentation of help in web form banner rule
3c6f17f to
c58f0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3298
The module adds configurable banners for backend form views. Define rules per model
(and optionally per view) to show context-aware alerts with a chosen severity (info/warning/danger).
Messages can be plain text with ${placeholders} or fully custom HTML; visibility,
severity, and values are computed server-side via a safe Python expression.
Banners are injected just before or after a target node (default: //sheet) and refresh
on form load/save/reload.
@qrtl QT5747