fix: statically register formatting and semantic tokens capabilities #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested it on my vscode, it doesn't not work if we always register them statically, so I turn to register them only if dynamic registering is not supported. Since we have made a mistake, I might delay to merge it in v0.12.2+ to reduce risk to break things. |
Sure, no problem, if you think it's better to wait in order not to break things, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #799.
Instead of dynamically registering formatting and semantic tokens capabilities, register them statically.
The toggles in the config works the same, for formatting and semantic highlighting. This, however, improves compatibility with some editors that do not support dynamic registering in their LSP client implementation.
I have tested the changes in VSCode (CodeOSS), Helix and Kate (does not support dynamic registration).