Edwin Thoretton thoretton-edwin

Pull Request Etiquette

Why do we use a Pull Request workflow?

PRs are a great way of sharing information, and can help us be aware of the changes that are occuring in our codebase. They are also an excellent way of getting peer review on the work that we do, without the cost of working in direct pairs.

Ultimately though, the primary reason we use PRs is to encourage quality in the commits that are made to our code repositories

Done well, the commits (and their attached messages) contained within tell a story to people examining the code at a later date. If we are not careful to ensure the quality of these commits, we silently lose this ability.

	plugins {
	java
	kotlin("jvm")
	}

	repositories {
	mavenCentral()
	}

	dependencies {

	import Foundation

	//sources :
	//https://blog.xebia.fr/2016/12/28/design-pattern-builder-et-builder-sont-dans-un-bateau/
	//https://jlordiales.me/2012/12/13/the-builder-pattern-in-practice/
	//https://pastebin.com/CXyxh658

	class Window { }
	class Door { }
	class Wall { }

	private fun <T> Observable<T>.subscribe(onNext:(T)-> Unit = {}, context: KFunction<out Unit>? = null) {
	this.subscribe({}, { ErrorController().onError("[ ${context?.name} ]",it) })
	}

	//exemple
	private fun onReceiveShareAction(userId: String) {
	messenger.sendShareMessage(Recipient(userId)).subscribe(context = ::onReceiveShareAction)
	}

	import 'package:flutter/material.dart';
	import 'theme.dart' as Theme;

	void main() {
	runApp(
	new MaterialApp(
	title: 'CompanyApp',
	color: Theme.CompanyColors.blue[500],
	theme: Theme.CompanyThemeData,
	home: new Scaffold(

	@interface GalleryImageViewCell : UICollectionViewCell <UIScrollViewDelegate>

	@property (weak, nonatomic) IBOutlet UIScrollView *scrollContainer;
	@property (weak, nonatomic) IBOutlet UIImageView *imageView;
	@property (weak, nonatomic) IBOutlet NSLayoutConstraint *scrollHeightLayoutConstraint;
	@property (weak, nonatomic) IBOutlet NSLayoutConstraint *scrollWidthLayoutConstraint;

	@end

	# excludes this file from merges
	# treats it like binary file
	*.pbxproj -crlf -diff -merge

	=> Error :
	duplicate simbols $viewController.variable in .o .....

	=> Solution :
	check import if .m is included

	=> Source :
	http://stackoverflow.com/questions/3231948/duplicate-symbol-issues


	BOOL linkedInIsInstalled =
	[[UIApplication sharedApplication] canOpenURL:[NSURL URLWithString:@"linkedin:#profile/9999"]];

	if(linkedInIsInstalled)
	{
	[[UIApplication sharedApplication]openURL:[NSURL URLWithString:@"linkedin:#profile/9999"]];
	}
	else
	{

	if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0)
	{
	[application registerUserNotificationSettings:
	[UIUserNotificationSettings settingsForTypes:
	(UIUserNotificationTypeSound \| UIUserNotificationTypeAlert) categories:nil]];

	[[UIApplication sharedApplication] registerForRemoteNotifications];
	}
	else
	{