Enter single quote in property value isn't handled properly by the Rule rewriter
Categories
(DevTools :: Inspector: Rules, defect, P2)
Tracking
(firefox-esr115 unaffected, firefox127 wontfix, firefox128 fixed, firefox129 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox127 | --- | wontfix |
| firefox128 | --- | fixed |
| firefox129 | --- | fixed |
People
(Reporter: 6k64x4ma, Assigned: nchevobbe)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0
Steps to reproduce:
- Go to GitHub page e.g. https://github.com/mozilla/gecko-dev
- Open the Inspector and select <body>.
- Click on
font-familyvalue. - Replace the value with
".
Actual results:
- The styles of the page is broken.
Pressing ESC key to cancel the edit does not return the page to its correct state.
Expected results:
- The page should not be broken like this.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=49aba74b154f99c1b31e609b596a468232697e5a&tochange=3bc4640f938f9922129f742e7f4556f203b0461d
| Assignee | ||
Comment 1•4 months ago
|
||
Thanks for the report.
I can reproduce on a simpler case: data:text/html,<meta charset=utf8><style>h1 { font-family: "Arial"; color: red; }</style><h1>Hello
When validating the " value, the stylesheet text is set to
h1 {
font-family: ";}
| Assignee | ||
Updated•4 months ago
|
| Assignee | ||
Updated•4 months ago
|
| Assignee | ||
Updated•4 months ago
|
Updated•4 months ago
|
Comment 2•4 months ago
|
||
Set release status flags based on info from the regressing bug 1889363
| Assignee | ||
Comment 3•4 months ago
|
||
When tracking tokens, we weren't handling the case of unterminated,
single-char quote.
Test cases are added to cover the fix.
Updated•4 months ago
|
Comment 5•4 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 6•4 months ago
|
||
When tracking tokens, we weren't handling the case of unterminated,
single-char quote.
Test cases are added to cover the fix.
Original Revision: https://phabricator.services.mozilla.com/D214917
Updated•4 months ago
|
Comment 7•4 months ago
|
||
beta Uplift Approval Request
- User impact if declined: setting property value with quotes in the DevTools rules view will mess up the rest of the stylesheet, which could change the whole page styling. This can't be reverted, unless the user reloads the page, which is extremely annoying
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: -
- Risk associated with taking this patch: low
- Explanation of risk level: one liner fix, covered by automated test, devtools only change
- String changes made/needed: -
- Is Android affected?: no
Updated•4 months ago
|
Updated•4 months ago
|
Description
•