[remote] DoubleClickTracker doesn't track multiple click sequences
Categories
(Remote Protocol :: WebDriver BiDi, defect, P2)
Tracking
(firefox122 fixed)
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert, Whiteboard: [webdriver:m9], [wptsync upstream][webdriver:relnote])
Attachments
(2 files, 1 obsolete file)
Currently the code for WebDriver BiDi doesn't correctly use the DoubleClickTracker and as such no dblclick events are getting emitted. Specifically here is the call to DoubleClickTracker.setClick() which increments the internal counter.
Marionette is doing that correctly in MarionetteEventsChild.sys.mjs.
Fixing that is removing a blocker for bug 1841008 to get triple clicks working as well.
I wonder if we have to share the dblclick state between Marionette and WebDriver BiDi, but I think that this is really a very rare situation so that we won't have to do that.
James, do you think otherwise?
Comment 1•1 year ago
|
||
It seems fine. My opinion is that for actions specifically the click-tracking state can be localised to a specific actions sequence (so you can guarantee a set of single clicks by breaking up the code into multiple action sequences). That also naturally means that you can't get a double click with a combination of HTTP and BiDi calls, so we don't need to share state between those.
| Reporter | ||
Comment 2•1 year ago
|
||
Thanks James. So lets consolidate the Marionette code with the Action implementation, which sounds fine and simplifies the code as well.
Given that this is a P1 blocker for Puppeteer I'm already going ahead and adding it for M9.
| Reporter | ||
Updated•1 year ago
|
| Reporter | ||
Updated•1 year ago
|
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 3•1 year ago
|
||
| Assignee | ||
Comment 4•1 year ago
|
||
Depends on D194613
| Assignee | ||
Comment 5•1 year ago
|
||
Remove empty lines in the test data to avoid differences in getSelection behaviour.
Depends on D194614
| Reporter | ||
Comment 6•1 year ago
|
||
Sasha, should we dupe bug 1841008 against this one given that you handle multi-click on this bug as well? If yes then we should probably rename this bug's summary as well.
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Updated•1 year ago
|
Comment 8•1 year ago
|
||
Comment on attachment 9365333 [details]
Bug 1864614 - [wdspec] Fix tests for triple clicks.
Revision D194615 was moved to bug 1795327. Setting attachment 9365333 [details] to obsolete.
Comment 11•11 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a5657402cf23
https://hg.mozilla.org/mozilla-central/rev/212399303055
Comment 13•11 months ago
|
||
(In reply to Pulsebot from comment #9)
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5657402cf23
[remote] Refactor DoubleClickTracker to work with multiple clicks sequences.
r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/212399303055
[wdspec] Update tests for multiple clicks in different command calls.
r=webdriver-reviewers,whimboo
== Change summary for alert #40542 (as of Mon, 04 Dec 2023 19:50:28 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 1% | Base Content JS | windows11-64-2009-shippable-qr | fission | 1,549,499.69 -> 1,528,896.00 |
| 1% | Base Content JS | linux1804-64-shippable-qr | fission | 1,546,895.33 -> 1,526,984.00 |
| 1% | Base Content JS | linux1804-64-shippable-qr | fission | 1,546,820.67 -> 1,526,984.00 |
| 1% | Base Content JS | macosx1015-64-shippable-qr | fission | 1,547,565.33 -> 1,527,784.00 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40542
Updated•11 months ago
|
| Reporter | ||
Updated•10 months ago
|
| Reporter | ||
Updated•6 months ago
|
Description
•