context switching should refer to target instead of thread
Categories
(DevTools :: Framework, task, P1)
Tracking
(Fission Milestone:M6a, firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: jlast, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(2 files)
[alex] In initial context selector patch, most of the patch mentions “thread” whereas this is rather a “target”.
registerThread
is a good example (link)
function registerThread(targetFront) {
return async function(dispatch) {
const threadFront = await targetFront.getFront("thread");
const thread = {
actor: threadFront.actor,
url: targetFront.url,
type: getTargetType(targetFront),
name: targetFront.name,
serviceWorkerStatus: targetFront.debuggerServiceWorkerStatus,
// NOTE: target is used because when the target is destroyed
// its ID and associated thread front are removed.
_targetFront: targetFront,
};
Isn’t the context selector more about targets than threads?
It is often better to work with a target as you can derive everything from it. While it is harder to get the console front, if you only have the thread front.
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
This is more consistent with the registerTarget action we
have
Depends on D68760
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c54971ad0117
https://hg.mozilla.org/mozilla-central/rev/c3c65ed42418
Description
•