Nothing Special   »   [go: up one dir, main page]

Closed Bug 1217569 Opened 9 years ago Closed 9 years ago

Mercurial 3.6 compatibility for pushlog

Categories

(Developer Services :: Mercurial: Pushlog, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(2 files)

There are some test failures with the pushlog extension on Mercurial 3.6RC. Looks like we'll need to perform a little porting.
pushlog: optionally perform dockeywords manipulation (bug 1217569); r?smacleod dockeywords was removed in Mercurial 3.6 and the behavior is automatic if the regular keywords dict is updated.
Attachment #8677937 - Flags: review?(smacleod)
pushlog: don't use weakref to repo (bug 1217569); r?smacleod The old behavior won't work in Mercurial 3.6 because of https://bz.mercurial-scm.org/show_bug.cgi?id=4915. This is arguably a bug in Mercurial. However, looking at the Mercurial code, relying on the same exact object for the repo is kinda difficult, as filters are involved and these create new repo instances. This commit removes the weakref. It also stops caching the pushlog instance on the repo. There is no state on the instance and recreating it is cheap. We arguably should have been doing this all along. Since this was the last piece of pushlog that didn't work with 3.6, I bumped the testwith property to indicate 3.6 compatibility.
Attachment #8677938 - Flags: review?(smacleod)
Attachment #8677937 - Flags: review?(smacleod) → review+
Comment on attachment 8677937 [details] MozReview Request: pushlog: optionally perform dockeywords manipulation (bug 1217569); r?smacleod https://reviewboard.mozilla.org/r/23057/#review20571
Comment on attachment 8677938 [details] MozReview Request: pushlog: don't use weakref to repo (bug 1217569); r?smacleod https://reviewboard.mozilla.org/r/23059/#review20573
Attachment #8677938 - Flags: review?(smacleod) → review+
Deployed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: