Closed
Bug 918189
Opened 11 years ago
Closed 11 years ago
Implement Node.convertPoint/Rect/QuadFromNode
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: roc, Assigned: roc)
References
(Blocks 3 open bugs)
Details
(Keywords: dev-doc-needed)
Attachments
(3 files, 6 obsolete files)
15.71 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
9.54 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Part 1.5: Implement GeometryUtils.convertPointFromNode, convertRectFromNode, and convertQuadFromNode
10.76 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Based on http://lists.w3.org/Archives/Public/www-style/2013Aug/0607.html and followup.
Updated•11 years ago
|
Keywords: dev-doc-needed
Comment 5•11 years ago
|
||
Will these interfaces be exposed on the global immediately even without a draft spec?
Comment 7•11 years ago
|
||
Comment on attachment 807614 [details] [diff] [review] Part 1: Implement Node.convertPoint/Rect/QuadFromNode Please ask again when the www-style discussion has settled or a spec is available.
Attachment #807614 -
Flags: review?(matspal)
Updated•11 years ago
|
Attachment #807615 -
Flags: review?(matspal)
Updated•11 years ago
|
Attachment #807616 -
Flags: review?(matspal)
Updated•11 years ago
|
Attachment #807617 -
Flags: review?(matspal)
Assignee | ||
Comment 8•11 years ago
|
||
These APIs are in a similar situation to getBoxQuads. We have consensus on how they should work, possibly except for some corner cases that haven't been discussed.
Attachment #807614 -
Attachment is obsolete: true
Attachment #807615 -
Attachment is obsolete: true
Attachment #807616 -
Attachment is obsolete: true
Attachment #807617 -
Attachment is obsolete: true
Attachment #8356417 -
Flags: review?(matspal)
Comment 10•11 years ago
|
||
Comment on attachment 8356417 [details] [diff] [review] Part 1: Implement GeometryUtils.convertPointFromNode, convertRectFromNode, and convertQudFromNode918189-implement I'm only reviewing the layout/* files. The rest should be reviewed by a DOM peer. > layout/base/GeometryUtils.cpp It's unfortunate with duplicated code for OwningGeometryNode and GeometryNode, is there no way to get a GeometryNode out of the former so they can share some code? For TransformCSSPoints - same comments as in bug 917755 comment 37.
Attachment #8356417 -
Flags: review?(matspal) → review-
Updated•11 years ago
|
Attachment #8356418 -
Flags: review?(matspal) → review+
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #10) > It's unfortunate with duplicated code for OwningGeometryNode and > GeometryNode, is there no way to get a GeometryNode out of the > former so they can share some code? I don't think so, at least not with significant changes to WebIDL codegen.
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #8356417 -
Attachment is obsolete: true
Attachment #8388511 -
Flags: review?(matspal)
Comment 14•11 years ago
|
||
Comment on attachment 8388511 [details] [diff] [review] Part 1: Implement GeometryUtils ConvertQuad/Rect/PointFromNode r=mats
Attachment #8388511 -
Flags: review?(matspal) → review+
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #8388513 -
Attachment is obsolete: true
Attachment #8388513 -
Flags: review?(mrbkap)
Attachment #8389634 -
Flags: review?(jst)
Updated•11 years ago
|
Attachment #8389634 -
Flags: review?(jst) → review+
Assignee | ||
Comment 16•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7e676be8fa0 https://hg.mozilla.org/integration/mozilla-inbound/rev/e60fe593236d https://hg.mozilla.org/integration/mozilla-inbound/rev/2f3187619c9e
Comment 17•11 years ago
|
||
Hi, sorry Roc had to backout this changes as part of https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=12e871cf1100 for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=36383057&tree=Mozilla-Inbound - not sure if this is a problem in the test or the other checkins
Assignee | ||
Comment 18•11 years ago
|
||
Relanded with test fixed. https://hg.mozilla.org/integration/mozilla-inbound/rev/3e6446f6d0e6 https://hg.mozilla.org/integration/mozilla-inbound/rev/48edbd324d0f https://hg.mozilla.org/integration/mozilla-inbound/rev/716f942b5798
Comment 19•11 years ago
|
||
Backed out for bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f011ba0f5e https://tbpl.mozilla.org/php/getParsedLog.php?id=36462189&tree=Mozilla-Inbound
Assignee | ||
Comment 20•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8b54afa1a7b https://hg.mozilla.org/integration/mozilla-inbound/rev/071acee02c25 https://hg.mozilla.org/integration/mozilla-inbound/rev/8c538fcbb578
Comment 21•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e8b54afa1a7b https://hg.mozilla.org/mozilla-central/rev/071acee02c25 https://hg.mozilla.org/mozilla-central/rev/8c538fcbb578
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 22•9 years ago
|
||
Comment on attachment 8389634 [details] [diff] [review] Part 1.5: Implement GeometryUtils.convertPointFromNode, convertRectFromNode, and convertQuadFromNode >+++ b/modules/libpref/src/init/all.js >@@ -1801,16 +1801,23 @@ pref("layout.css.DOMQuad.enabled", true) > > // Is support for GeometryUtils.getBoxQuads enabled? > #ifdef RELEASE_BUILD > pref("layout.css.getBoxQuads.enabled", false); > #else > pref("layout.css.getBoxQuads.enabled", true); > #endif > >+// Is support for GeometryUtils.getBoxQuads enabled? >+#ifdef RELEASE_BUILD >+pref("layout.css.convertFromNode.enabled", false); I just ran across this section of all.js & noticed that there's a copy-paste typo in the comment here - the latter "Is support for..." comment needs s/getBoxQuads/convert*FromNode/. Pushed a comment-only followup to make that tweak: https://hg.mozilla.org/integration/mozilla-inbound/rev/52e1fb0b5576
You need to log in
before you can comment on or make changes to this bug.
Description
•