Remove UA styles for :is(article, aside, nav, section) h1 (Nightly only)
Categories
(Core :: Layout, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: zcorpan, Assigned: zcorpan)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
See https://github.com/whatwg/html/issues/7867
Since the affected number of pages is relatively high, there is a web compat risk with this change. See analysis at https://github.com/whatwg/html/issues/7867#issuecomment-1977647444
I think it's still worthwhile to change, since the current behavior is confusing.
We can use @media (-moz-bool-pref: "...")
in the UA stylesheet. This allows us to change the pref on Nightly only first, and revert the pref on stable if needed.
Assignee | ||
Comment 1•7 months ago
|
||
Updated•7 months ago
|
Assignee | ||
Updated•7 months ago
|
Comment 6•7 months ago
•
|
||
I see it enabled by default in Nightly. Good riddance! Is there a flag that would allow testing this behavior once Firefox 125 stable is released? We’re planning to mention it in the release notes as an experimental removal.
Assignee | ||
Comment 7•7 months ago
|
||
(In reply to Vadim Makeev from comment #6)
I see it enabled by default in Nightly. Good riddance! Is there a flag that would allow testing this behavior once Firefox 125 stable is released? We’re planning to mention it in the release notes as an experimental removal.
Yes, the pref is layout.css.h1-in-section-ua-styles.enabled
.
Comment 8•6 months ago
|
||
FYI, PR for 125 release notes featuring the removal in the experimental features.
Comment 9•5 months ago
|
||
@zcorpan: looks like we've had this enabled-by-default on Nightly for 2 months now. Possibly worth considering next-steps (in followup bugs):
-
Assuming things look good, maybe it's worth shipping this to early-beta, too, to see if we get any additional webcompat fallout? (changing the pref to
@IS_NOT_EARLY_BETA_OR_EARLIER@
) -
I think you were planning to submit a spec PR per https://github.com/whatwg/html/issues/7867#issuecomment-1999318189 ; want to be sure that's still on your radar.
-
(and if/when the spec is updated, we should of course update WPT expectations as well, since at least https://wpt.fyi/results/html/rendering/non-replaced-elements/sections-and-headings/headings-styles.html depends on the traditional behavior right now and fails in Firefox Nightly as a result)
Comment 10•5 months ago
|
||
(probably not a high priority, of course; I just happened to notice today when twisniewski and I were looking at some (nightly) Firefox-only WPT test failures.)
Assignee | ||
Comment 11•5 months ago
|
||
Thanks for the ping. Yes, we can expand to early beta, but first I'd like to check that other vendors are indeed onboard. Changing the wpt's should be done at the same time as the spec change is landed.
Description
•