Don't swallow errors #384

rpdelaney · 2023-09-11T19:38:43Z

Change 'pattern does not match any files' warning to fatal
Also raise a fatal error if the config file is not valid

Closes #383

softprops · 2024-03-08T21:09:57Z

src/main.ts

@@ -25,7 +25,7 @@ async function run() {
    if (config.input_files) {
      const patterns = unmatchedPatterns(config.input_files);
      patterns.forEach((pattern) =>
-        console.warn(`🤔 Pattern '${pattern}' does not match any files.`)
+        throw new Error(`⚠️  Pattern '${pattern}' does not match any files.`)


makes sense to me. thanks @rpdelaney

softprops · 2024-03-08T21:39:25Z

this should be available in the new v2 tag

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [softprops/action-gh-release](https://togithub.com/softprops/action-gh-release) | action | patch | `v2.0.0` -> `v2.0.1` | --- ### Release Notes <details> <summary>softprops/action-gh-release (softprops/action-gh-release)</summary> ### [`v2.0.1`](https://togithub.com/softprops/action-gh-release/releases/tag/v2.0.1) [Compare Source](https://togithub.com/softprops/action-gh-release/compare/v2.0.0...v2.0.1) - Add support for make_latest property [https://github.com/softprops/action-gh-release/pull/304](https://togithub.com/softprops/action-gh-release/pull/304) via [@samueljseay](https://togithub.com/samueljseay) - Fail run if files setting contains invalid patterns [https://github.com/softprops/action-gh-release/pull/384](https://togithub.com/softprops/action-gh-release/pull/384) via [@rpdelaney](https://togithub.com/rpdelaney) - Add support for proxy env variables (don't use node-fetch) [https://github.com/softprops/action-gh-release/pull/386](https://togithub.com/softprops/action-gh-release/pull/386)/ via [@timor-raiman](https://togithub.com/timor-raiman) - Suppress confusing warning when input_files is empty [https://github.com/softprops/action-gh-release/pull/389](https://togithub.com/softprops/action-gh-release/pull/389) via [@Drowze](https://togithub.com/Drowze) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

rpdelaney added 2 commits September 11, 2023 14:47

Change 'pattern does not match any files' warning to fatal

89b2397

Fixes softprops#383

Raise a fatal error if the config file is not valid

f2fbdbb

Related to softprops#383

rpdelaney mentioned this pull request Nov 28, 2023

Do not raise misleading warning #389

Merged

softprops reviewed Mar 8, 2024

View reviewed changes

softprops merged commit fe71fd3 into softprops:master Mar 8, 2024

softprops mentioned this pull request Mar 9, 2024

current version does not match any files issue, previous version is okay #416

Closed

rpdelaney deleted the rpd-dont_swallow_error branch March 9, 2024 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't swallow errors #384

Don't swallow errors #384

Don't swallow errors #384

Don't swallow errors #384

Conversation

Choose a reason for hiding this comment