Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix PEP 646 support of tuple unpacking #4440

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: fix PEP 646 support of tuple unpacking #4440

merged 1 commit into from
Aug 26, 2024

Conversation

terencehonles
Copy link
Contributor
@terencehonles terencehonles commented Aug 22, 2024 •
edited
Loading

Description

This change fixes unpacking a tuple or generic type when *args is a type variable tuple.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

JelleZijlstra
JelleZijlstra requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good catch. However, as it is a change in style, it should be applied only to Black's preview style.

@terencehonles
Copy link
Contributor Author

Thanks, this is a good catch. However, as it is a change in style, it should be applied only to Black's preview style.

Guidance on that probably would have been useful, but I believe I may have figured it out

JelleZijlstra
JelleZijlstra approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
github-actions bot commented Aug 22, 2024 •
edited
Loading

diff-shades reports zero changes comparing this PR (fd311b9) to main (699b45a).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra
JelleZijlstra reviewed Aug 22, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@JelleZijlstra
Copy link
Collaborator

There's a CI failure that looks unrelated to your change, probably due to a typing change in a dependency. I can look into it over the next few days.

@terencehonles
fix: fix PEP 646 support of tuple unpacking
fd311b9 
This change fixes unpacking a tuple or generic type when *args is a type
variable tuple.
@terencehonles
Copy link
Contributor Author

There's a CI failure that looks unrelated to your change, probably due to a typing change in a dependency. I can look into it over the next few days.

I fixed the last lint error by updating the schema

@JelleZijlstra JelleZijlstra merged commit 823a7b0 into psf:main Aug 26, 2024
46 checks passed
@JelleZijlstra
Copy link
Collaborator

Thank you!

@terencehonles terencehonles deleted the fix-pep-646-support branch August 26, 2024 15:52
@MichaReiser MichaReiser mentioned this pull request Sep 16, 2024
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencehonles @JelleZijlstra