Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage-package-manager-versions flag not propagating to workspaces #8667

Closed
3 of 4 tasks
y-nk opened this issue Oct 18, 2024 · 0 comments · Fixed by #8671
Closed
3 of 4 tasks

manage-package-manager-versions flag not propagating to workspaces #8667

y-nk opened this issue Oct 18, 2024 · 0 comments · Fixed by #8671
Assignees
@zkochan
Labels
type: bug

Comments

@y-nk
Copy link
y-nk commented Oct 18, 2024 •
edited
Loading

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.11

Which area(s) of pnpm are affected? (leave empty if unsure)

Package manager compatibility

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  1. Create a pnpm workspace with 2 workspaces.
  2. Have manage-package-manager-versions=true in .npmrc at root level
  3. Have packageManager="pnpm@9.1.0" in root level's package.json
  4. pnpm --version → 9.1.0
  5. cd workspaceA
  6. pnpm --version → not 9.1.0

Describe the Bug

the pnpm version of a workspace is not matching the one defined in the root level of the monorepo

Expected Behavior

pnpm version should remain the same as the monorepo root one unless explicitly redefined in each workspace.

Additional Notes

if it's not a bug, it could be a feature flag such as workspace-inherit-package-manager-version 🙏

Which Node.js version are you using?

20.18

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

github action-runner (ubuntu)
@y-nk y-nk added the type: bug label Oct 18, 2024
@zkochan zkochan self-assigned this Oct 18, 2024
zkochan added a commit that referenced this issue Oct 18, 2024
@zkochan
fix: every command should read settings from the root workspace project
c636449 
close #8667
@zkochan zkochan mentioned this issue Oct 18, 2024
Merged
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Oct 28, 2024
@renovate
chore(deps): update pnpm to v9.12.3
3a926f9 
##### [v9.12.3](https://github.com/pnpm/pnpm/blob/HEAD/pnpm/CHANGELOG.md#9123)

##### Patch Changes

-   Don't purge `node_modules`, when typing "n" in the prompt that asks whether to remove `node_modules` before installation [#8655](pnpm/pnpm#8655).
-   Fix a bug causing pnpm to infinitely spawn itself when `manage-package-manager-versions=true` is set and the `.tools` directory is corrupt.
-   Use `crypto.hash`, when available, for improved performance [#8629](pnpm/pnpm#8629).
-   Fixed a race condition in temporary file creation in the store by including worker thread ID in filename. Previously, multiple worker threads could attempt to use the same temporary file. Temporary files now include both process ID and thread ID for uniqueness [#8703](pnpm/pnpm#8703).
-   All commands should read settings from the `package.json` at the root of the workspace [#8667](pnpm/pnpm#8667).
-   When `manage-package-manager-versions` is set to `true`, errors spawning a self-managed version of `pnpm` will now be shown (instead of being silent).
-   Pass the find command to npm, it is an alias for npm search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkochan zkochan

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: every command should read settings from the root workspace project pnpm/pnpm
2 participants
@y-nk @zkochan