fix: include_tracing_fields arg to control unvetted data in rust_tracing integration #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3780 +/- ##
==========================================
+ Coverage 84.26% 84.30% +0.03%
==========================================
Files 137 137
Lines 14558 14561 +3
Branches 2459 2460 +1
==========================================
+ Hits 12268 12275 +7
+ Misses 1530 1528 -2
+ Partials 760 758 -2
|
9817d2a
to
10e3d9c
Compare
This was referenced Nov 15, 2024
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 21, 2024
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
JoshuaMoelans
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 22, 2024
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented my suggestion from #3778 so that if anton agrees we can merge this before the weekend
this PR renames the
send_sensitive_dataflag toinclude_tracing_fields. the data in question is generally data the user expectstracingto record or data they explicitly passed into a log statement to be recorded, so if we call it "sensitive" they may think we are referring to something elsealso, this PR applies the same condition to both
on_record()andon_new_span(). both callbacks set the same fields, so they should either both be redacted or both be allowed. previously onlyon_record()had the condition applied.Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.