fix: update tokenless branch logic #1650
Conversation
| env: | ||
| CC_BRANCH: ${{ inputs.override_branch }} | ||
| GITHUB_EVENT_PULL_REQUEST_HEAD_LABEL: ${{ github.event.pull_request.head.label }} | ||
| GITHUB_EVENT_PULL_REQUEST_REPO_FULL_NAME: ${{ github.event.pull_request.repo.full_name }} |
There was a problem hiding this comment.
Greetings.
I am not sure where did full_name come from. This event variable does not exist in the documentation, and it is also not outputting anything when I am testing it in my repositories (not forks).
And due to that fact, the following check here:
if [ -z "$CC_BRANCH" ] && [ -z "$CODECOV_TOKEN" ] && [ "${GITHUB_EVENT_PULL_REQUEST_REPO_FULL_NAME}" != "$GITHUB_REPOSITORY"
is always false when I am upgrading to codecov-action v5, which leads to some side effects with the token check.
So, unless I am missing something, I think it is a bug.
Best,
Rust
There was a problem hiding this comment.
@amureki there was a slight bug, but that has been fixed in 5.0.3. As for why is it empty, it seems that this variable when not from a fork will be empty, thus the issue you were seeing.
There was a problem hiding this comment.
Oh, got it @thomasrockhu-codecov
Thank you for the explanation and resolving the issue!
No description provided.