Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(B024): #14455 add annotated but unassgined class variables #14502

Merged

Conversation

cmp0xff
Copy link
Contributor
@cmp0xff cmp0xff commented Nov 20, 2024

Summary

Closes #14455, migrated from astral-sh/docs#106.

Test Plan

Updating the documentation probably does not need a test.

@cmp0xff cmp0xff changed the title doc(B024): #14455 add annotated but unassgined class variables astral-sh/docs/#106 doc(B024): #14455 add annotated but unassgined class variables https://github.com/astral-sh/docs/pull/106 Nov 20, 2024
@cmp0xff cmp0xff changed the title doc(B024): #14455 add annotated but unassgined class variables https://github.com/astral-sh/docs/pull/106 doc(B024): #14455 add annotated but unassgined class variables Nov 20, 2024
@cmp0xff cmp0xff force-pushed the hotfix/cmp0xff/#14455-b024-class-variable branch 2 times, most recently from 8d22dfc to 6b5ae73 Compare November 20, 2024 21:02
Copy link
Contributor
github-actions bot commented Nov 20, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+2 -2 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)

DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)

- disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods
+ disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods or properties

apache/airflow (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods
+ airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods or properties

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
B024 4 2 2 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+2 -2 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)

DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

- disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods
+ disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods or properties

apache/airflow (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods
+ airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods or properties

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
B024 4 2 2 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Nov 20, 2024
Copy link
Collaborator
@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! Minor nit and then we'll merge it in.

scripts/generate_mkdocs.py Outdated Show resolved Hide resolved
@cmp0xff cmp0xff force-pushed the hotfix/cmp0xff/#14455-b024-class-variable branch from 6b5ae73 to 680b199 Compare November 21, 2024 11:46
Copy link
Collaborator
@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for the contribution! (I'm gonna merge this right after the 0.8 release so I don't mess up the changelog 😄 )

@MichaReiser
Copy link
Member

@dylwil3 it's fine to merge documentation changes because we rarely mention them in the changelog 😅

@dylwil3 dylwil3 merged commit b9da430 into astral-sh:main Nov 21, 2024
20 checks passed
@cmp0xff cmp0xff deleted the hotfix/cmp0xff/#14455-b024-class-variable branch November 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B024: ruff in pre-commit fails to recognise B024 with the presence of a class variable
3 participants