-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(B024): #14455 add annotated but unassgined class variables #14502
doc(B024): #14455 add annotated but unassgined class variables #14502
Conversation
8d22dfc
to
6b5ae73
Compare
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
B024 | 4 | 2 | 2 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+2 -2 violations, +0 -0 fixes in 2 projects; 52 projects unchanged)
DisnakeDev/disnake (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
- disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods + disnake/app_commands.py:468:7: B024 `ApplicationCommand` is an abstract base class, but it has no abstract methods or properties
apache/airflow (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods + airflow/secrets/base_secrets.py:26:7: B024 `BaseSecretsBackend` is an abstract base class, but it has no abstract methods or properties
Changes by rule (1 rules affected)
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
B024 | 4 | 2 | 2 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! Minor nit and then we'll merge it in.
crates/ruff_linter/src/rules/flake8_bugbear/rules/abstract_base_class.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_bugbear/rules/abstract_base_class.rs
Outdated
Show resolved
Hide resolved
6b5ae73
to
680b199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for the contribution! (I'm gonna merge this right after the 0.8 release so I don't mess up the changelog 😄 )
@dylwil3 it's fine to merge documentation changes because we rarely mention them in the changelog 😅 |
Summary
Closes #14455, migrated from astral-sh/docs#106.
Test Plan
Updating the documentation probably does not need a test.