Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

Paladox (Paladox)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:51 AM (529 w, 5 d)
Availability
Available
LDAP User
Paladox
MediaWiki User
Unknown

I live in the United Kingdom GMT/BST(UTC+0, UTC+1)

I have autism.

🇪🇺 🇬🇧

Recent Activity

Thu, Nov 28

Paladox created T381101: UploadComplete hook triggers before entries are written to table making getUploader() return null.
Thu, Nov 28, 1:02 PM · MediaWiki-Uploading

Mon, Nov 25

Paladox closed T380791: Error: Interface "MediaWiki\Hook\SpecialWhatLinksHereQueryHook" not found on MediaWiki 1.42 as Declined.

This was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1071145 . The hook was added recently for 1.43 so the version requirement of Extension:Translate probably needs to be raised to 1.43.

Mon, Nov 25, 9:40 PM · MediaWiki-extensions-Translate
Paladox created T380791: Error: Interface "MediaWiki\Hook\SpecialWhatLinksHereQueryHook" not found on MediaWiki 1.42.
Mon, Nov 25, 8:41 PM · MediaWiki-extensions-Translate
Paladox renamed T216508: Upgrade OpenLayers to version 10 from Upgrade OpenLayers to version 5 (or 6) to Upgrade OpenLayers to version 10.
Mon, Nov 25, 3:31 PM · MediaWiki-extensions-Page_Forms
Paladox added a comment to T216508: Upgrade OpenLayers to version 10.

There's no project for OpenLayers tho.

Mon, Nov 25, 3:30 PM · MediaWiki-extensions-Page_Forms
Paladox added a comment to T216508: Upgrade OpenLayers to version 10.

@Paladox - sorry for the extremely long delay on this; OpenLayers is now already up to version 7, I believe. Is this an issue for the Page Forms extension, though, or for the OpenLayers extension?

Mon, Nov 25, 3:29 PM · MediaWiki-extensions-Page_Forms

Sun, Nov 24

Paladox closed T346355: [Event Platform] Error: Call to a member function exists() on null (via EventBus PageChangeEventSerializer) as Resolved.

This was fixed 5 months ago. Closing as resolved.

Sun, Nov 24, 8:46 PM · Event-Platform, Data-Engineering, Wikimedia-production-error

Sat, Nov 23

Paladox closed T380681: Title: isValid() is broken for ipv6 addresses as Invalid.

Just gonna decline as I guess it's expected extensions handle this?

Sat, Nov 23, 8:58 PM · affects-Miraheze, MediaWiki-General
Paladox changed the status of T380681: Title: isValid() is broken for ipv6 addresses from Invalid to Declined.
Sat, Nov 23, 8:56 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380681: Title: isValid() is broken for ipv6 addresses.

Think I fixed HAWelcome with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/HAWelcome/+/1095303 which I guess makes it a extension problem?

Sat, Nov 23, 5:17 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380681: Title: isValid() is broken for ipv6 addresses.

Or we can wrap https://github.com/wikimedia/mediawiki/blob/master/includes/title/Title.php#L906 in sanitizeIP.

Sat, Nov 23, 4:52 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380681: Title: isValid() is broken for ipv6 addresses.

I'm not entirely sure what the fix would be. We can either remove that piece of code or we could do use prettifyIP()?

Sat, Nov 23, 4:39 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380681: Title: isValid() is broken for ipv6 addresses.

This is our ip I'm using to demonstrate the problem but it's HAWelcome that was having the problem with some users ip. I cannot share that ip for gdpr reasons, hence why I'm using our ip to demonstrate.

Sat, Nov 23, 4:25 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380681: Title: isValid() is broken for ipv6 addresses.

https://github.com/wikimedia/mediawiki/blob/master/includes/title/MediaWikiTitleCodec.php#L556 seems to be the cause.

Sat, Nov 23, 4:21 PM · affects-Miraheze, MediaWiki-General
Paladox reopened T380681: Title: isValid() is broken for ipv6 addresses as "Open".

Nvm, it's correct

Sat, Nov 23, 4:18 PM · affects-Miraheze, MediaWiki-General
Paladox closed T380681: Title: isValid() is broken for ipv6 addresses as Invalid.

Seems I got it wrong.

Sat, Nov 23, 4:16 PM · affects-Miraheze, MediaWiki-General
Paladox updated the task description for T380681: Title: isValid() is broken for ipv6 addresses.
Sat, Nov 23, 4:08 PM · affects-Miraheze, MediaWiki-General
Paladox renamed T380681: Title: isValid() is broken for ipv6 addresses from Titlke: isValid() is broken for ipv6 addresses to Title: isValid() is broken for ipv6 addresses.
Sat, Nov 23, 4:04 PM · affects-Miraheze, MediaWiki-General
Paladox created T380681: Title: isValid() is broken for ipv6 addresses.
Sat, Nov 23, 4:04 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T380191: PageForms AutoeditAPI: Use of MediaWiki\EditPage\EditPage::internalAttemptSave was deprecated in MediaWiki 1.43.

Think this may be able to be replaced with attemptSave().

Sat, Nov 23, 2:20 PM · affects-translatewiki.net, MediaWiki-extensions-Page_Forms

Fri, Nov 22

Paladox added a comment to T254209: Spike of impossible "Cannot declare class" fatal errors (opcache).

This looks similar to T378006 which there's a patch for https://github.com/wikimedia/mediawiki/commit/8f7b4abd751f9f4e402b104f19b1e48559d7834f

Fri, Nov 22, 9:14 PM · serviceops, Wikimedia-production-error

Mon, Nov 18

Paladox triaged T380223: Getting SMW property values leads to "Table name component contains unexpected quote or dot character" error in MW 1.42 as High priority.
Mon, Nov 18, 9:08 PM · MediaWiki-extensions-Page_Forms
Paladox added a comment to T380223: Getting SMW property values leads to "Table name component contains unexpected quote or dot character" error in MW 1.42.

What versions of Page Forms and Semantic MediaWiki are you running? Most importantly, does your SMW code already include that fix?

Mon, Nov 18, 8:07 PM · MediaWiki-extensions-Page_Forms
Paladox created T380224: Table name component contains unexpected quote or dot character.
Mon, Nov 18, 7:35 PM · MediaWiki-extensions-CommentStreams
Paladox created T380223: Getting SMW property values leads to "Table name component contains unexpected quote or dot character" error in MW 1.42.
Mon, Nov 18, 7:35 PM · MediaWiki-extensions-Page_Forms

Sun, Nov 17

Paladox added a comment to T292322: Support large files in Shellbox.

Support for large file objects support should probably be added to ->quickStore.

Sun, Nov 17, 7:03 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), MW-1.43-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), SRE-swift-storage, Shellbox, serviceops, MW-on-K8s

Tue, Nov 12

Paladox added a comment to T379656: refreshLinksPrioritized: Job is re-run even when it says it failed due to Revision x not current.

Or we can use something like https://github.com/wikimedia/mediawiki/blob/master/includes/jobqueue/jobs/ThumbnailRenderJob.php#L173. Prevent retry’s when it errors out with revision not current? As it implies a new job has been created already?

Tue, Nov 12, 11:57 PM · MW-1.42-notes, MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), MW-1.43-release, Developer Productivity, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Paladox added a comment to T379656: refreshLinksPrioritized: Job is re-run even when it says it failed due to Revision x not current.
Tue, Nov 12, 9:32 PM · MW-1.42-notes, MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), MW-1.43-release, Developer Productivity, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Paladox added a comment to T379656: refreshLinksPrioritized: Job is re-run even when it says it failed due to Revision x not current.

https://github.com/wikimedia/mediawiki/blob/master/includes/jobqueue/jobs/RefreshLinksJob.php#L505 Should return false. Then https://github.com/wikimedia/mediawiki/blob/master/includes/jobqueue/jobs/RefreshLinksJob.php#L381 should check for false and then return false and keep the check for null. https://github.com/wikimedia/mediawiki/blob/master/includes/jobqueue/jobs/RefreshLinksJob.php#L288 Should check for false and then return true.

Tue, Nov 12, 7:42 PM · MW-1.42-notes, MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), MW-1.43-release, Developer Productivity, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data
Paladox created T379658: refreshLinks: Lower log level to warning if job fails with revision x is not current.
Tue, Nov 12, 5:23 PM · MediaWiki-Page-derived-data
Paladox created T379656: refreshLinksPrioritized: Job is re-run even when it says it failed due to Revision x not current.
Tue, Nov 12, 5:22 PM · MW-1.42-notes, MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), MW-1.43-release, Developer Productivity, MediaWiki-Platform-Team (Radar), MediaWiki-Page-derived-data

Sat, Nov 9

Paladox closed T379466: Test failure on Math with REL1_42 as Resolved.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1088716 fixed it, closing this as resolved.

Sat, Nov 9, 4:56 PM · Math
Paladox added a comment to T379466: Test failure on Math with REL1_42.

Seems https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1088716 this will fix it?

Sat, Nov 9, 4:23 PM · Math
Paladox added a comment to T379466: Test failure on Math with REL1_42.

There's also https://integration.wikimedia.org/ci/job/mwext-codehealth-patch/138977/console

Sat, Nov 9, 4:09 PM · Math
Paladox created T379466: Test failure on Math with REL1_42.
Sat, Nov 9, 4:00 PM · Math
Paladox added a comment to T379342: TemplateStyles on REL1_42 causing issues with scoped-callback v5 which is incompatible with 1.42.

Using wikimedia/services in version 3.0.0 together with wikimedia/scoped-callback version 5.0.0 does not work as the bump in 26dbce1abbaf4ebf856a1c6d2a79d9ea130ad31d is not released yet (tracked via T379384)

TemplateStyles requires wikimedia/css-sanitizer version ^5.1.0 || ^5.2.0, your composer seems to use 5.4.0 released with 7d0a15de3d234fd083aa6b0cb3fb6ac817089ece including the wikimedia/scopedcallback bump. But older scopedcallback are also allowed. composer should install the compatible version for scoped callback.

Possible fixes:

  • Release css-sanitizer 5.4.1 with scopedcallback 4.0.0 to remove 5.0.0 and release css-sanitizer 6.0.0 afterwards as it contains breaking change
  • Use ~5.1.0 || ~5.2.0 in TemplateStyles to avoid update to 5.4.0 (this does not help existing installs when running composer update)
  • Release scoped callback 5.0.1 without breaking change?

Running composer update right now on master also brings in this breaking change when not using the merge plugin, needs bump of services in core to fix.

Sat, Nov 9, 3:06 PM · MW-1.42-release, TemplateStyles
Paladox added a comment to T379463: TemplateStyles fails on MW 1.43 with "ArgumentCountError: Too few arguments to function Wikimedia\ScopedCallback::consume()".

Think this will impact MW 1.42 as well?

Sat, Nov 9, 2:57 PM · Patch-For-Review, MW-1.43-release, affects-Miraheze, TemplateStyles
Paladox added a comment to T379463: TemplateStyles fails on MW 1.43 with "ArgumentCountError: Too few arguments to function Wikimedia\ScopedCallback::consume()".

Oh, it's because of ^5.1.0 https://github.com/wikimedia/mediawiki-extensions-TemplateStyles/blob/REL1_43/composer.json#L4

Sat, Nov 9, 2:52 PM · Patch-For-Review, MW-1.43-release, affects-Miraheze, TemplateStyles
Paladox created T379463: TemplateStyles fails on MW 1.43 with "ArgumentCountError: Too few arguments to function Wikimedia\ScopedCallback::consume()".
Sat, Nov 9, 2:42 PM · Patch-For-Review, MW-1.43-release, affects-Miraheze, TemplateStyles

Fri, Nov 8

Paladox closed T374494: Database calls inside onUserGetRights hook cause tests to fail as Resolved.
Fri, Nov 8, 12:24 PM · MW-1.43-notes, MW-1.42-notes, MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), MediaWiki-Core-Tests

Oct 31 2024

Paladox merged T274706: rebuildtextindex.php fails due to "Error 1406: Data too long for column 'si_title' at row 1" into T231827: Data too long for column 'si_title'.
Oct 31 2024, 12:24 PM · MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), affects-Miraheze, Patch-For-Review, Discovery-Search, MediaWiki-Search
Paladox merged task T274706: rebuildtextindex.php fails due to "Error 1406: Data too long for column 'si_title' at row 1" into T231827: Data too long for column 'si_title'.
Oct 31 2024, 12:22 PM · Discovery-Search, MediaWiki-Search, MediaWiki-Maintenance-system
Paladox closed T231827: Data too long for column 'si_title' as Resolved.
Oct 31 2024, 12:20 PM · MW-1.43-notes, MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), affects-Miraheze, Patch-For-Review, Discovery-Search, MediaWiki-Search
Paladox created T378698: Switch searchindex to InnoDB.
Oct 31 2024, 12:19 PM · MediaWiki-Search, Discovery-Search

Oct 19 2024

Paladox added a comment to T375487: Deleted en-gb translations not exported into release branch as part of localisation updates.

Seems https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051869 also brought in a broken word for en-gb.

Oct 19 2024, 4:25 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.42-notes, LPL Essential (LPL Essential 2024 Jul-Oct), MediaWiki-extensions-Translate, MW-1.42-release, MW-1.41-release, MW-1.39-release, translatewiki.net
Paladox added a comment to T375487: Deleted en-gb translations not exported into release branch as part of localisation updates.

Seems that en-gb broke with https://github.com/wikimedia/mediawiki/commit/20514cb388923c875f045f36b564e2f7b6d46ba9#diff-007f8b6baea4fb3f292c276dfa5fdb0eea6b409ced3166a5a9f3832c31fb7072

Oct 19 2024, 3:59 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.42-notes, LPL Essential (LPL Essential 2024 Jul-Oct), MediaWiki-extensions-Translate, MW-1.42-release, MW-1.41-release, MW-1.39-release, translatewiki.net

Oct 11 2024

Paladox created T377031: [Tabs extension] Use of MediaWiki\Parser\Parser::$tabsData was deprecated in MediaWiki 1.42.
Oct 11 2024, 5:36 PM · MediaWiki-extensions-Other, Patch-For-Review
Paladox created T376997: Creation of dynamic property MediaWiki\Title\Title::$approvedRevID is deprecated.
Oct 11 2024, 1:47 PM · PHP 8.2 support, MediaWiki-extensions-Approved-Revs

Oct 10 2024

Paladox added a comment to T376549: Error: Call to a member function addModules() on null.

If I works for you on mw 1.42 then it's safe for you to merge.

Oct 10 2024, 3:45 PM · PHP 8.1 support, MediaWiki-extensions-Cargo
Paladox added a comment to T376549: Error: Call to a member function addModules() on null.

I feel like that will work.

Oct 10 2024, 3:45 PM · PHP 8.1 support, MediaWiki-extensions-Cargo

Oct 6 2024

Paladox added a comment to T376549: Error: Call to a member function addModules() on null.

Hi - what version of Cargo? For what it's worth, the current/old code works fine me, on MW 1.43.

Oct 6 2024, 11:35 PM · PHP 8.1 support, MediaWiki-extensions-Cargo

Oct 5 2024

Paladox added a comment to T376549: Error: Call to a member function addModules() on null.

Running MediaWiki 1.42 and php 8.2

Oct 5 2024, 10:06 PM · PHP 8.1 support, MediaWiki-extensions-Cargo
Paladox created T376549: Error: Call to a member function addModules() on null.
Oct 5 2024, 10:05 PM · PHP 8.1 support, MediaWiki-extensions-Cargo

Sep 15 2024

Paladox added a comment to T374772: Link with ampersand is broken in commit messages.

I think this is fixed with https://github.com/GerritCodeReview/gerrit/commit/380b6a844ce52556d905322e675fdf99cefe1bcd

Sep 15 2024, 11:29 AM · Upstream, Release-Engineering-Team, Gerrit

Jul 1 2024

Paladox added a comment to T368912: Gerrit email about added or updated HTTP password is a bit misleading.

I've fixed the url with https://gerrit-review.googlesource.com/c/gerrit/+/432038

Jul 1 2024, 2:12 PM · Gerrit

Jun 27 2024

Paladox added a comment to T367029: "Press c to comment" is placed incorrectly when using Firefox 126 and 128 on macOS.

For some reason the fix didn't merge up, so it's not in 3.10. I've cherry picked the fix to the branch here https://gerrit-review.googlesource.com/c/gerrit/+/431657.

Jun 27 2024, 9:31 AM · Gerrit (Gerrit 3.10), Regression, Upstream

Jun 25 2024

Paladox added a comment to T359821: Configure Gerrit to use conflictStyle diff3.

I added support for diff3 to rebasing/cherry-picking in the UI. https://gerrit-review.googlesource.com/c/gerrit/+/431417

Jun 25 2024, 1:55 PM · Gerrit (Gerrit 3.10)
Paladox added a comment to T359821: Configure Gerrit to use conflictStyle diff3.

Backported to gerrit 3.10 here: https://gerrit-review.googlesource.com/c/gerrit/+/431417

Jun 25 2024, 1:55 PM · Gerrit (Gerrit 3.10)

Jun 19 2024

Paladox added a comment to T359821: Configure Gerrit to use conflictStyle diff3.

Needs to be added to https://github.com/GerritCodeReview/gerrit/blob/dafe2982321d068b6cd157c9d42d06151f3d0aaf/java/com/google/gerrit/server/change/RebaseChangeOp.java#L550 as well.

Jun 19 2024, 11:28 AM · Gerrit (Gerrit 3.10)

Jun 13 2024

Paladox added a comment to T358762: Gerrit commit message formatting does not handle angle-bracketed URLs well, adds extra semicolon.

Found the commit that fixes this https://gerrit-review.googlesource.com/c/gerrit/+/393975. This was incorrectly reverted in https://gerrit-review.googlesource.com/c/gerrit/+/395140 by mistake. I've re-done it with https://gerrit-review.googlesource.com/c/gerrit/+/429837.

Jun 13 2024, 12:44 PM · Patch-For-Review, Upstream, Gerrit (Gerrit 3.8)
Paladox added a comment to T358762: Gerrit commit message formatting does not handle angle-bracketed URLs well, adds extra semicolon.

Fun thing I have noticed is the <a> element shallows the closing bracket and the href contains the closing bracket. So it is more complicated than just a ; being added. I think the link is generated by:

polygerrit-ui/app/utils/link-util.ts
function createLinkTemplate(
  href: string,
  displayText: string,
  prefix?: string,
  suffix?: string
) {
  return `${
    prefix ?? ''
  }<a href="${href}" rel="noopener noreferrer" target="_blank">${displayText}</a>${
    suffix ?? ''
  }`;
}

Which would be fed:

prefix<
hrefhttps://example.com>
displayTexthttps://example.com>
suffix;

The method is apparently called solely for processing commentlink which are regex feeding the above function. Maybe one of our configured comment link is the cause of the issue?

Jun 13 2024, 12:20 PM · Patch-For-Review, Upstream, Gerrit (Gerrit 3.8)

Jun 11 2024

Paladox added a comment to T367135: "Collapse" link on add/edit reviewers screen is showing weird icons.

Looks like the repo is now https://github.com/googlefonts/roboto-classic and not https://github.com/google/roboto

Jun 11 2024, 1:58 PM · Gerrit (Gerrit 3.9), Upstream

Jun 10 2024

Paladox added a comment to T367094: Related changes in the gerrit UI can no longer be opened in a new tab (due to AutoScroll browser extension).

Did you clear your browser cache? it works for me.

Jun 10 2024, 5:40 PM · Gerrit

Jun 8 2024

Paladox added a comment to T362269: Unchanged file with unresolved comment doesn't show up in file list.

Does this work for you now?

@Paladox: Has something related changed server-side in the meantime?

Jun 8 2024, 3:12 PM · Gerrit

Jun 1 2024

Paladox added a comment to T344891: Missing sign in links on mobile.

This will be fixed with T365328.

On some cheap Android phone it initially looks like this:

Screenshot_20240601-100958.png (1×720 px, 206 KB)

It was not super obvious that I have to drag the viewport sideways to get this:

Screenshot_20240601-101123.png (1×720 px, 143 KB)

Yeh, it’s a hack. I’ve fixed it on the master branch of Gerrit by creating a mobile view. Please visit https://gerrit-review.googlesource.com/q/status:open+-is:wip to see what it’s like and do give feedback!

Jun 1 2024, 9:18 AM · Gerrit, Upstream, Mobile

May 24 2024

Krinkle awarded T363918: Gerrit recheck button a Orange Medal token.
May 24 2024, 4:51 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit

May 19 2024

Paladox added a comment to T339096: Syntax highlightning of Embedded Puppet (EPP) files in Gerrit.

Added here: https://gerrit-review.googlesource.com/c/gerrit/+/426018

May 19 2024, 3:50 PM · Upstream, Gerrit
Paladox added a comment to T339096: Syntax highlightning of Embedded Puppet (EPP) files in Gerrit.

Oh... I have the permissions to create one. Have done so here: https://github.com/highlightjs/highlightjs-epp

May 19 2024, 3:12 PM · Upstream, Gerrit
Paladox added a comment to T339096: Syntax highlightning of Embedded Puppet (EPP) files in Gerrit.

I'd ask them to create a hjs repo for you similar to highlightjs-closure-templates so that we can include it in gerrit.

May 19 2024, 3:05 PM · Upstream, Gerrit
Paladox added a comment to T355259: Gerrit notification emails are missing the content of inline comments on unchanged files.

Does this issue still happen to you?

May 19 2024, 3:04 PM · Gerrit
Paladox added a comment to T344891: Missing sign in links on mobile.

This will be fixed with T365328.

May 19 2024, 2:31 PM · Gerrit, Upstream, Mobile

May 9 2024

Paladox added a comment to T364484: Gerrit email subject begins with “size bucket” ([XS], [S], [M] [L], [XL]) since 6 May 2024.

I note the review for this change mentioned making the message longer: https://gerrit.wikimedia.org/r/c/operations/puppet/+/1027726

May 9 2024, 4:57 PM · Gerrit

May 1 2024

Paladox added a comment to T363918: Gerrit recheck button.

an example I found https://github.com/GerritCodeReview/plugins_checks-jenkins/blob/master/web/fetcher.ts#L139

May 1 2024, 6:10 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit
Paladox added a comment to T363918: Gerrit recheck button.

I think that we would *use* https://github.com/GerritCodeReview/gerrit/blob/4f82b6d02ac5517e8db3771b17fa28da0a0b9677/polygerrit-ui/app/models/checks/checks-model.ts#L158 in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/gerrit/+/refs/heads/deploy/wmf/stable-3.8/plugins/wm-checks-api.js#631.

May 1 2024, 4:08 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit

Apr 30 2024

Paladox added a comment to T214631: Create a plugin that add's recheck as a button to PolyGerrit's ui.

Guessing this no longer works since gerrit moved to lit, is that right @Paladox ?

(also, seems we've undeployed the wikimedia gerrit plugin judging from our latest release)

I do wonder how trivial this would be to implement as a new js plugin? This is something that someone mentioned in the latest developer satisfaction survey comments.

Apr 30 2024, 6:22 PM · Gerrit

Apr 23 2024

Paladox closed T361915: Adjust (or disable) H108 as Resolved.

I’ve disabled it. Thanks.

Apr 23 2024, 10:13 AM · Phabricator
Paladox closed T361915: Adjust (or disable) H108, a subtask of T330794: Disable Audit application in Phabricator, as Resolved.
Apr 23 2024, 10:13 AM · Phabricator (2024-07-23)

Apr 19 2024

Paladox added a comment to T337502: Gerrit daemon on a new replica refuses to start due to lack of `groups` index.

Is this still an issue?

Apr 19 2024, 2:24 PM · Gerrit
Paladox added a comment to T310077: The UI "rebase" feature is working incorrectly since the last gerrit update for chained patches.

Is this still an issue (also a + is that gerrit supports rebasing chained changes now via the UI).

Apr 19 2024, 2:06 PM · Gerrit
Paladox added a comment to T292858: Gerrit timeout when cloning mediawiki/core.

Is this still an issue?

Apr 19 2024, 2:04 PM · Release-Engineering-Team (Seen), Gerrit
Paladox added a comment to T257705: Horizontal scrollbars are missing when needed in Gerrit.

(This was discovered by someone else)

Apr 19 2024, 8:35 AM · Upstream, Gerrit
Paladox added a comment to T257705: Horizontal scrollbars are missing when needed in Gerrit.

The above shows then end “. It’s just not obvious as it has a similar colour to the tabs when zoomed out but is blue zoomed in.

Apr 19 2024, 8:35 AM · Upstream, Gerrit

Apr 18 2024

Paladox added a comment to T344891: Missing sign in links on mobile.

This appears to be because items are being pushed out of screen. I did a hack https://gerrit-review.googlesource.com/c/gerrit/+/420278. It's an ugly hack but it does the job. The better fix and something I'm pushing and looking at is to create a mobile optimised header that pushes these drop downs to a side bar (or aka hamburger).

Apr 18 2024, 9:55 PM · Gerrit, Upstream, Mobile
Paladox moved T261263: Rename gerrit account `dannys712-main` to `dannys712` from Bugs & stuff to Repo Admin on the Gerrit board.
Apr 18 2024, 9:50 PM · User-DannyS712, Gerrit
Paladox added a comment to T257705: Horizontal scrollbars are missing when needed in Gerrit.

I think this may be fixed in gerrit 3.9 based on testing locally. I can't reproduce on master but I remember work on the diff screen being done for that release.

Apr 18 2024, 12:08 PM · Upstream, Gerrit
Paladox added a comment to T257705: Horizontal scrollbars are missing when needed in Gerrit.

Oh... It misses the end " bit.

Apr 18 2024, 12:00 PM · Upstream, Gerrit
Paladox added a comment to T257705: Horizontal scrollbars are missing when needed in Gerrit.

This seems fixed at least scroll bars show for me now.

Apr 18 2024, 11:59 AM · Upstream, Gerrit
Paladox moved T260647: Rename account Zoranzoki21 to Kizule on Gerrit from Bugs & stuff to Repo Admin on the Gerrit board.
Apr 18 2024, 11:58 AM · Gerrit, wikitech.wikimedia.org, LDAP
Paladox added a comment to T180297: Allow searching for 'state:active', 'state:read_only', 'state:hidden' via web interface.

You can search state:active or state:read-only in the UI. Doesn't seem to support hidden.

Apr 18 2024, 11:55 AM · Upstream, Gerrit

Apr 17 2024

Paladox added a comment to T343471: Gerrit does not send email when a new patchset is created using the web interface.

Does this still not work (gerrit is now on 3.8)?

AIUI the web editor in gerrit is broken since we moved to 3.8, so I don't think we can test yet.

Apr 17 2024, 12:47 PM · Upstream, Gerrit
Paladox added a comment to T343471: Gerrit does not send email when a new patchset is created using the web interface.

Does this still not work (gerrit is now on 3.8)?

Apr 17 2024, 12:39 PM · Upstream, Gerrit

Apr 15 2024

Paladox added a comment to T362269: Unchanged file with unresolved comment doesn't show up in file list.

Does this work for you now?

Apr 15 2024, 4:00 PM · Gerrit
Paladox added a comment to T362545: Inline editing of files no longer works in Gerrit.

I think you need to clear your browser cache. It works for me and Polymer isn't use any more for the codemirror gerrit plugin.

Apr 15 2024, 3:53 PM · Gerrit

Mar 31 2024

Paladox closed T361449: CVE-2024-40600: Metrolook skin: stored XSS via MediaWiki:Sidebar as Resolved.

Closing as resolved. I'm not sure what the process is for opening the task to public? Is it once all those changes were merged that it can?

Mar 31 2024, 9:54 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team
Paladox added a comment to T361449: CVE-2024-40600: Metrolook skin: stored XSS via MediaWiki:Sidebar.

I've merged it and back ported it to all the stable releases up to 1.39 (so 1.41 & 1.40)

Mar 31 2024, 9:49 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team
Paladox added a comment to T361449: CVE-2024-40600: Metrolook skin: stored XSS via MediaWiki:Sidebar.

Thank you for reporting! Would you mind doing the patch on Gerrit and I’ll +2 it as soon as you’ve done it please?

Mar 31 2024, 7:57 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team

Mar 20 2024

Paladox added a comment to T360550: Gerrit 3.7.8: CI has completed checks. Reload the change view? RELOAD button doesn't work.

From what I remember it's https://github.com/GerritCodeReview/gerrit/blob/stable-3.7/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts#L629. I last took a dive years ago so I'm a little fuzzy. But I do remember it was within there.

Mar 20 2024, 7:44 PM · Gerrit (Gerrit 3.7)
Paladox added a comment to T360550: Gerrit 3.7.8: CI has completed checks. Reload the change view? RELOAD button doesn't work.

This is fixed in gerrit 3.9. This is to do with the migration to lit that to get it working needed to use the change model. The changes couldn't be back-ported because they are big and would require a lot being backported.

Mar 20 2024, 7:42 PM · Gerrit (Gerrit 3.7)

Mar 11 2024

Paladox closed T355931: Gerrit 3.7: copyable Change URLs broken as Resolved.
Mar 11 2024, 2:44 PM · Upstream, Gerrit (Gerrit 3.7)
Paladox closed T355650: Starred changes are not displayed as starred in change lists in Gerrit 3.7.6 as Resolved.
Mar 11 2024, 2:43 PM · Gerrit (Gerrit 3.7), Upstream, Regression