Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

Dark mode and colored table cells with links. Make links underlined black in all namespaces, not just article space
Open, MediumPublic

Description

Background

WikimediaMessages has styles that detect tables with background colors, and changes the links inside them to black with underline so they are legible in dark mode. This currently only applies to article pages because it conflicts with portal pages and main pages where all colors are stripped (often resulting in black links on black backgrounds). We would like this to apply to all pages.

Original discussion here:
*https://www.mediawiki.org/wiki/Talk:Reading/Web/Accessibility_for_reading#Link_color_in_dark_mode_is_faded_in_table_cells_with_background_colors

To summarize the thread, it is very confusing in dark mode when colored table cells with links have different link colors in different namespaces.

Some current help I wrote up is here:
*https://en.wikipedia.org/wiki/Help:Table#Color_contrast_of_links_in_dark_mode
*https://en.wikipedia.org/wiki/Help:Table#Color_contrast_with_visited_and_unvisited_links
Above 2 subsections are part of this section started by others:
*https://en.wikipedia.org/wiki/Help:Table#Colors_in_tables

Almost anytime functionality is removed from article talk pages there are problems. People do a lot of collaborative work on article talk pages. Also in sandboxes. I have hundreds of sandboxes linked to many discussions.

User story

  • As an editor the different treatment of tables makes it almost impossible to understand how tables will work in dark mode
    • on some tables on article talk pages, user sandboxes, help pages, Wikipedia namespace info pages, etc.. People can't figure out what links in a table with some colored cells will look like in article namespace by working elsewhere. I need to see the exact same thing in a sandbox as in the article a table ends up in. Same for article talk pages when I am showing table options to other editors. Same for doc and help pages to show table options to editors.
  • As a reader, many pages are inaccessible in dark mode due to poor color contrast

Requirements

  • Add task requirements. Requirements should be user-centric, well-defined, unambiguous, implementable, testable, consistent, and comprehensive

BDD

  • For QA engineer to fill out

Test Steps

Colored table cells with links are common. In sports articles for example. See:
https://en.wikipedia.org/wiki/List_of_top-division_football_clubs_in_UEFA_countries#Spain
Unfortunately, in dark mode the colored cell links are only underlined black in article namespace. Not in template, help, talk, user, and other namespaces. For example see the Spain table template from the above-linked article:
https://en.wikipedia.org/wiki/Template:2022%E2%80%9323_La_Liga_table

Design

  • Add mockups and design requirements

Acceptance criteria

  • The table fixing CSS is applied to all pages regardless of namespace
  • The table fixing CSS does not conflict with portal pages or the main page rules in WikimediaMessages

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Timeshifter renamed this task from Dark mode and colored table cell links. Make links underlined black in all namespaces, not just article space to Dark mode and colored table cells with links. Make links underlined black in all namespaces, not just article space.Oct 10 2024, 6:53 PM
Timeshifter updated the task description. (Show Details)
ovasileva triaged this task as Medium priority.Oct 17 2024, 5:52 PM
ovasileva added a project: patch-welcome.
ovasileva moved this task from Incoming to Groomed on the Web-Team-Backlog board.