Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

Adapt Add a link to dark mode
Closed, ResolvedPublic

Description

Dark mode is available for a large number of users, including the ones who use Suggested edits, and, specifically, Add a link.

At the moment, the chip that highlights the potential link location in the text is white, with white text. It makes it impossible to use.

Add a link chip in dark mode.jpeg (371×530 px, 99 KB)

Thanks to HaukweKwor for reporting this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1066877 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(styles): darkmode: make add a link suggestions readable

https://gerrit.wikimedia.org/r/1066877

Change #1066877 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(styles): darkmode: make add a link suggestions readable

https://gerrit.wikimedia.org/r/1066877

I'm not clear why Dennis moved this to Triaged and not into QA.
As far as I can see this task was resolved and the patch was merged, so we might as well test and resolve this.

Screenshot 2024-10-04 at 12.35.07 PM.png (590×920 px, 210 KB)

Etonkovidova claimed this task.
Etonkovidova subscribed.

I'm not clear why Dennis moved this to Triaged and not into QA.
As far as I can see this task was resolved and the patch was merged, so we might as well test and resolve this.

Screenshot 2024-10-04 at 12.35.07 PM.png (590×920 px, 210 KB)

Thank, @KStoller-WMF for checking! I double-checked in wmf.25 (current production) - the issue has been fixed.