Nothing Special   »   [go: up one dir, main page]

Page MenuHomePhabricator

[VISUAL CHANGE] [Config] Enable responsive table behaviour on all skins
Open, MediumPublic

Description

Background

We have been working on updating tables so they do not overlap the sidebars. We have enabled this behaviour on wikis where Vector 2022 is not the default skin and have identified several bugs. When we have confidence, we can deploy this to all wikis

User story

As a user I do not want tables to ever overlap sidebars.

Requirements

  • We have reviewed the potential blockers on T361737, listed them here, and fixes for those blockers are in production.

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Fix blockers
  • Enable on one wiki first
  • Enable on all wikis

Communication criteria - does this need an announcement or discussion?

We will need to communicate to editors, that:

  1. if tables are inadvertently broken by this change, they will need to fix that by wrapping their table in a DIV (per instructions in T367248)
  2. All large tables where the behaviour is wanted should be updated to be wrapped with div.noresize, to avoid reflows due to our JavaScript kicking in.

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson updated the task description. (Show Details)

I was looking at responsive tables, and discovered that changing their display property and setting overflow:auto is no longer breaking their table semantics (and thus screenreader accessibility), which was a big reason perviously for not deploying this methodology more widely, or for wrapping them with a div with noresize to make them scrollable instead.

Apparently it already worked in Firefox, it was fixed in Chrome 80 in Feb 2020, and fixed for Safari in October 2023 (see the history and various update notes at https://adrianroselli.com/2018/02/tables-css-display-properties-and-aria.html )

Jdlrobson lowered the priority of this task from High to Medium.Sep 24 2024, 9:43 PM