Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T298677

IP Information checkboxes can have incorrect enabled states when they are set globally
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

After settings the two checkboxes in the IP Information section globally, the state of I agree to use this information for my patrolling and anti-vandalism work in Special:Preferences can be incorrect:

  1. After checking Show the IP Information tool on Special:Contributions page for IP addresses, it is enabled even if the local exception is not checked
  2. If you then check the local exception, it becomes disabled

I agree to use this information for my patrolling and anti-vandalism work should be enabled when Show the IP Information tool on Special:Contributions page for IP addresses is checked (this is how the two options behave when not set globally), but only if its local exception is also checked.

The way to work around this bug I have found is to check the local exception for I agree to use this information for my patrolling and anti-vandalism work first and then check Show the IP Information tool on Special:Contributions page for IP addresses.

Steps to reproduce problem
  1. Login as a user with Administrator rights
  2. Go to Special:GlobalPreferences (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences)
  3. Make Show the IP Information tool on Special:Contributions page for IP addresses and I agree to use this information for my patrolling and anti-vandalism work global options
  4. Go to Special:Preferences
  5. Check Show the IP Information tool on Special:Contributions page for IP addresses and its local exception (you will have to check the latter first)

Expected behavior: I agree to use this information for my patrolling and anti-vandalism work remains disabled
Observed behavior: I agree to use this information for my patrolling and anti-vandalism work becomes enabled, even though the local exception has not been checked

  1. Check the local exception for I agree to use this information for my patrolling and anti-vandalism work

Expected behavior: I agree to use this information for my patrolling and anti-vandalism work is enabled
Observed behavior: I agree to use this information for my patrolling and anti-vandalism work is disabled

Environment

Browser: Firefox 78
Wiki(s): https://en.wikipedia.beta.wmflabs.org GlobalPreferences 0.1.2 (c91eb42) 15:24, 9 December 2021.

Screenshots

Initial state of those two options in Special:Preferences:

ipinfo_options_before.png (176×625 px, 22 KB)

After checking the first option:
ipinfo_options_after.png (169×609 px, 22 KB)

After checking the local exception for the second option:
ipinfo_options_after_2.png (174×622 px, 23 KB)

Details

SubjectRepoBranchLines +/-
Use native method to disable checkbox conditionallymediawiki/extensions/IPInfomaster+5 -48
Customize query in gerrit

Related Objects

Event Timeline

dom_walden created this task.Jan 6 2022, 9:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 9:51 AM
dom_walden updated the task description. (Show Details)Jan 6 2022, 9:53 AM
dom_walden updated the task description. (Show Details)
Func edited projects, added IP Info; removed MediaWiki-extensions-GlobalPreferences.Jan 10 2022, 7:17 AM
Func subscribed.

Should adapt in the IPInfo side, use 'disable-if' attr in the form descriptor instead.

gerritbot added a comment.Jan 10 2022, 7:25 AM

Change 752272 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/IPInfo@master] Use native method to disable checkbox conditionally

https://gerrit.wikimedia.org/r/752272

gerritbot added a project: Patch-For-Review.Jan 10 2022, 7:25 AM
Tchanders added a project: Anti-Harassment (The Letter Song).Jan 11 2022, 5:20 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Jan 13 2022, 6:44 AM

Change 752272 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Use native method to disable checkbox conditionally

https://gerrit.wikimedia.org/r/752272

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 13 2022, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 13 2022, 7:10 AM
STran moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jan 13 2022, 12:08 PM
dom_walden removed a project: Community-Tech.Jan 13 2022, 2:13 PM
dom_walden added a project: QTE-TestingOverview.Jan 13 2022, 4:54 PM
dom_walden moved this task from Inbox to Dom on the QTE-TestingOverview board.
dom_walden moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Jan 18 2022, 7:55 AM

I cannot reproduce this bug anymore.

I did not test very thoroughly because IPInfo will soon be disabled as a global preference (T299368).

Test Environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (41a1e35) 07:12, 17 January 2022.

Func claimed this task.Jan 23 2022, 10:03 AM
Niharika closed this task as Resolved.Feb 17 2022, 1:42 AM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits